The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.torque.TorqueInstance.managers; locked 62% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 773 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.torque.criteria.Criterion.getPreparedStatementReplacements() may expose internal representation by returning Criterion.preparedStatementReplacements | MALICIOUS_CODE | EI_EXPOSE_REP | 283 | Medium |
| new org.apache.torque.criteria.Criterion(Object, Object, SqlEnum, String, Object[]) may expose internal representation by storing an externally mutable object into Criterion.preparedStatementReplacements | MALICIOUS_CODE | EI_EXPOSE_REP2 | 145 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.torque.om.ComboKey.getValue() may expose internal representation by returning ComboKey.key | MALICIOUS_CODE | EI_EXPOSE_REP | 171 | Medium |
| org.apache.torque.om.ComboKey.setValue(SimpleKey[]) may expose internal representation by storing an externally mutable object into ComboKey.key | MALICIOUS_CODE | EI_EXPOSE_REP2 | 94 | Medium |
| org.apache.torque.om.ComboKey.equals(Object) is unusual | STYLE | EQ_UNUSUAL | 194-209 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.torque.sql.WhereClauseExpression.getPreparedStatementReplacements() may expose internal representation by returning WhereClauseExpression.preparedStatementReplacements | MALICIOUS_CODE | EI_EXPOSE_REP | 185 | Medium |
| new org.apache.torque.sql.WhereClauseExpression(Object, SqlEnum, Object, String, Object[]) may expose internal representation by storing an externally mutable object into WhereClauseExpression.preparedStatementReplacements | MALICIOUS_CODE | EI_EXPOSE_REP2 | 98 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| A prepared statement is generated from a nonconstant String at org.apache.torque.util.BasePeerImpl.doInsert(ColumnValues, Connection) | SECURITY | SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING | 789 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.torque.util.Criteria$Criterion is serializable and an inner class | BAD_PRACTICE | SE_INNER_CLASS | 3069-3473 | Medium |
| Should org.apache.torque.util.Criteria$Criterion be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 3069-3473 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Inconsistent synchronization of org.apache.torque.util.LargeSelect.lastResults; locked 50% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 354 | Medium |
| Exception is caught when Exception is not thrown in org.apache.torque.util.LargeSelect.run() | STYLE | REC_CATCH_EXCEPTION | 670 | Medium |
| org.apache.torque.util.LargeSelect.getResults(int, int) calls Thread.sleep() with a lock held | MT_CORRECTNESS | SWL_SLEEP_WITH_LOCK_HELD | 441 | Medium |
| org.apache.torque.util.LargeSelect.stopQuery() calls Thread.sleep() with a lock held | MT_CORRECTNESS | SWL_SLEEP_WITH_LOCK_HELD | 738 | Medium |