FindBugs Results

The following document contains the results of FindBugs.

Summary

Files Errors
21 42

Files

Files Violations
org.apache.torque.task.TorqueSQLTask 1
org.apache.torque.task.TorqueSQLExec$Transaction 1
org.apache.torque.task.TorqueDocumentationTask 1
org.apache.torque.task.TorqueDataDumpTask$TableTool 1
org.apache.torque.task.TorqueDataSQLTask 1
org.apache.torque.task.TorqueDataDumpTask 1
org.apache.torque.task.TorqueSQLExec 6
org.apache.torque.task.TorqueDataModelTask 2
org.apache.torque.task.TorqueSQLTransformTask 2
org.apache.torque.engine.platform.PlatformFactory 1
org.apache.torque.engine.database.transform.SQLToAppData 9
org.apache.torque.engine.database.transform.XmlToData 2
org.apache.torque.engine.database.transform.DTDResolver 1
org.apache.torque.engine.database.transform.XmlToAppData 1
org.apache.torque.engine.database.model.Table 1
org.apache.torque.engine.database.model.ForeignKey 4
org.apache.torque.engine.database.model.JavaNameGenerator 2
org.apache.torque.engine.database.model.Column 2
org.apache.torque.engine.database.model.IdMethodParameter 1
org.apache.torque.engine.database.transform.XmlToData$ColumnValue 1
org.apache.torque.engine.database.transform.XmlToData$DataRow 1

org.apache.torque.task.TorqueSQLTask

Violation Line Priority
OS: org.apache.torque.task.TorqueSQLTask.createSqlDbMap() may fail to close stream on exception 138 Low

org.apache.torque.task.TorqueSQLExec$Transaction

Violation Line Priority
OS: org.apache.torque.task.TorqueSQLExec$Transaction.runTransaction(java.io.PrintStream) may fail to close stream on exception 925 Low

org.apache.torque.task.TorqueDocumentationTask

Violation Line Priority
ISC: Method org.apache.torque.task.TorqueDocumentationTask.initControlContext() needlessly instantiates a class that only supplies static methods 65 Low

org.apache.torque.task.TorqueDataDumpTask$TableTool

Violation Line Priority
SQL: Method org.apache.torque.task.TorqueDataDumpTask$TableTool.fetch(String) passes a nonconstant String to an execute method on an SQL statement 273 Low

org.apache.torque.task.TorqueDataSQLTask

Violation Line Priority
OS: org.apache.torque.task.TorqueDataSQLTask.initControlContext() may fail to close stream on exception 189 Low

org.apache.torque.task.TorqueDataDumpTask

Violation Line Priority
ISC: Method org.apache.torque.task.TorqueDataDumpTask.initControlContext() needlessly instantiates a class that only supplies static methods 209 Low

org.apache.torque.task.TorqueSQLExec

Violation Line Priority
Dm: Method org.apache.torque.task.TorqueSQLExec.setRdbms(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 362 Low
Dm: Method org.apache.torque.task.TorqueSQLExec.setVersion(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 372 Low
Dm: Method org.apache.torque.task.TorqueSQLExec.isValidRdbms(java.sql.Connection) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 728 Low
OS: org.apache.torque.task.TorqueSQLExec.execute() may fail to close stream on exception 421 Low
WMI: Method org.apache.torque.task.TorqueSQLExec.execute() makes inefficient use of keySet iterator instead of entrySet iterator 438 Normal
WMI: Method org.apache.torque.task.TorqueSQLExec.execute() makes inefficient use of keySet iterator instead of entrySet iterator 463 Normal

org.apache.torque.task.TorqueDataModelTask

Violation Line Priority
Dm: org.apache.torque.task.TorqueDataModelTask.execute() invokes dubious Boolean constructor; use Boolean.valueOf(...) instead 541 Normal
EI: org.apache.torque.task.TorqueDataModelTask.getDataModelDbMap() may expose internal representation by returning org.apache.torque.task.TorqueDataModelTask.dataModelDbMap 153 Normal

org.apache.torque.task.TorqueSQLTransformTask

Violation Line Priority
OS: org.apache.torque.task.TorqueSQLTransformTask.execute() may fail to close stream on exception 106 Low
REC: Method org.apache.torque.task.TorqueSQLTransformTask.execute() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught 115 Low

org.apache.torque.engine.platform.PlatformFactory

Violation Line Priority
Dm: Method org.apache.torque.engine.platform.PlatformFactory.getClassnameFor(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 86 Low

org.apache.torque.engine.database.transform.SQLToAppData

Violation Line Priority
Dm: Method org.apache.torque.engine.database.transform.SQLToAppData.create() invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 150 Low
Dm: Method org.apache.torque.engine.database.transform.SQLToAppData.create_Table_Column(org.apache.torque.engine.database.model.Table) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 206 Low
Dm: Method org.apache.torque.engine.database.transform.SQLToAppData.create_Table_Column_Primary(org.apache.torque.engine.database.model.Table) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 232 Low
Dm: Method org.apache.torque.engine.database.transform.SQLToAppData.create_Table_Column_Unique(org.apache.torque.engine.database.model.Table) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 279 Low
Dm: Method org.apache.torque.engine.database.transform.SQLToAppData.create_Table_Column_Foreign(org.apache.torque.engine.database.model.Table) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 314 Low
Dm: Method org.apache.torque.engine.database.transform.SQLToAppData.create_Table_Column_Data(org.apache.torque.engine.database.model.Table) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 402 Low
Dm: Method org.apache.torque.engine.database.transform.SQLToAppData.execute() invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 570 Low
UwF: Field not initialized in constructor: org.apache.torque.engine.database.transform.SQLToAppData.appDataDB -1 Low
UwF: Field not initialized in constructor: org.apache.torque.engine.database.transform.SQLToAppData.tokens -1 Low

org.apache.torque.engine.database.transform.XmlToData

Violation Line Priority
RI: Class org.apache.torque.engine.database.transform.XmlToData implements same interface as superclass. -1 Low
UwF: Field not initialized in constructor: org.apache.torque.engine.database.transform.XmlToData.data -1 Low

org.apache.torque.engine.database.transform.DTDResolver

Violation Line Priority
UI: Usage of GetResource in org.apache.torque.engine.database.transform.DTDResolver.readFromClasspath(String) may be unsafe if class is extended 103 Normal

org.apache.torque.engine.database.transform.XmlToAppData

Violation Line Priority
REC: Method org.apache.torque.engine.database.transform.XmlToAppData.startElement(String,String,String,org.xml.sax.Attributes) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught 327 Low

org.apache.torque.engine.database.model.Table

Violation Line Priority
Dm: org.apache.torque.engine.database.model.Table.toString() invokes dubious Boolean constructor; use Boolean.valueOf(...) instead 1017 Normal

org.apache.torque.engine.database.model.ForeignKey

Violation Line Priority
Dm: Method org.apache.torque.engine.database.model.ForeignKey.normalizeFKey(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 83 Low
UwF: Field not initialized in constructor: org.apache.torque.engine.database.model.ForeignKey.onDelete -1 Low
UwF: Field not initialized in constructor: org.apache.torque.engine.database.model.ForeignKey.onUpdate -1 Low
UwF: Field not initialized in constructor: org.apache.torque.engine.database.model.ForeignKey.parentTable -1 Low

org.apache.torque.engine.database.model.JavaNameGenerator

Violation Line Priority
Dm: Method org.apache.torque.engine.database.model.JavaNameGenerator.underscoreMethod(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 107 Low
Dm: Method org.apache.torque.engine.database.model.JavaNameGenerator.underscoreOmitSchemaMethod(String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 151 Low

org.apache.torque.engine.database.model.Column

Violation Line Priority
Dm: Method org.apache.torque.engine.database.model.Column.getPeerJavaName() invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 331 Low
Dm: Method org.apache.torque.engine.database.model.Column.setTypeFromString(String,String) invokes dubious String.toUpperCase() or String.toLowerCase; use the Locale parameterized version instead 945 Low

org.apache.torque.engine.database.model.IdMethodParameter

Violation Line Priority
UwF: Field not initialized in constructor: org.apache.torque.engine.database.model.IdMethodParameter.parentTable -1 Low

org.apache.torque.engine.database.transform.XmlToData$ColumnValue

Violation Line Priority
SIC: Should org.apache.torque.engine.database.transform.XmlToData$ColumnValue be a _static_ inner class? -1 Normal

org.apache.torque.engine.database.transform.XmlToData$DataRow

Violation Line Priority
SIC: Should org.apache.torque.engine.database.transform.XmlToData$DataRow be a _static_ inner class? -1 Normal