Checkstyle Results

The following document contains the results of Checkstyle .

Summary

Files Infos Warnings Errors
155 0 0 210

Files

Files I W E
org/apache/torque/Torque.java 0 0 5
org/apache/torque/TorqueInstance.java 0 0 17
org/apache/torque/TorqueRuntimeException.java 0 0 1
org/apache/torque/adapter/DBCloudscape.java 0 0 2
org/apache/torque/adapter/DBFactory.java 0 0 2
org/apache/torque/adapter/DBMM.java 0 0 2
org/apache/torque/adapter/DBOracle.java 0 0 1
org/apache/torque/adapter/DBSybase.java 0 0 2
org/apache/torque/avalon/Torque.java 0 0 4
org/apache/torque/avalon/TorqueComponent.java 0 0 6
org/apache/torque/manager/AbstractBaseManager.java 0 0 8
org/apache/torque/manager/MethodCacheKey.java 0 0 21
org/apache/torque/manager/MethodResultCache.java 0 0 4
org/apache/torque/map/DatabaseMap.java 0 0 1
org/apache/torque/oid/IDBroker.java 0 0 7
org/apache/torque/oid/IDGeneratorFactory.java 0 0 1
org/apache/torque/om/DateKey.java 0 0 1
org/apache/torque/om/NumberKey.java 0 0 1
org/apache/torque/om/StringKey.java 0 0 1
org/apache/torque/util/BasePeer.java 0 0 1
org/apache/torque/util/CountHelper.java 0 0 1
org/apache/torque/util/Criteria.java 0 0 44
org/apache/torque/util/LargeSelect.java 0 0 7
org/apache/torque/util/Query.java 0 0 24
org/apache/torque/util/SQLBuilder.java 0 0 2
org/apache/torque/util/SqlEnum.java 0 0 31
org/apache/torque/util/SqlExpression.java 0 0 6
org/apache/torque/util/Transaction.java 0 0 2
org/apache/torque/util/VillageUtils.java 0 0 5

org/apache/torque/Torque.java

Error Line
Error Utility classes should not have a public or default constructor. 45
Error Comment matches to-do format 'TODO:'. 96
Error Line has trailing spaces. 269
Error Line has trailing spaces. 282
Error Line has trailing spaces. 289

org/apache/torque/TorqueInstance.java

Error Line
Error Line has trailing spaces. 163
Error 'cast' is not followed by whitespace. 168
Error Line has trailing spaces. 169
Error Line has trailing spaces. 176
Error Line has trailing spaces. 181
Error Comment matches to-do format 'TODO:'. 287
Error Line has trailing spaces. 442
Error Line has trailing spaces. 692
Error 'cast' is not followed by whitespace. 698
Error Line has trailing spaces. 699
Error 'cast' is not followed by whitespace. 700
Error Line has trailing spaces. 805
Error Line has trailing spaces. 826
Error Line has trailing spaces. 832
Error Line has trailing spaces. 839
Error 'cast' is not followed by whitespace. 846
Error Line has trailing spaces. 880

org/apache/torque/TorqueRuntimeException.java

Error Line
Error Line has trailing spaces. 225

org/apache/torque/adapter/DBCloudscape.java

Error Line
Error '132' is a magic number. 83
Error '3' is a magic number. 110

org/apache/torque/adapter/DBFactory.java

Error Line
Error Class DBFactory should be declared as final. 37
Error '40' is a magic number. 42

org/apache/torque/adapter/DBMM.java

Error Line
Error '>=' is not followed by whitespace. 147
Error ')' is preceded with whitespace. 147

org/apache/torque/adapter/DBOracle.java

Error Line
Error Comment matches to-do format 'TODO:'. 233

org/apache/torque/adapter/DBSybase.java

Error Line
Error '(' is followed by whitespace. 169
Error ')' is preceded with whitespace. 169

org/apache/torque/avalon/Torque.java

Error Line
Error Line has trailing spaces. 120
Error Line has trailing spaces. 123
Error Line has trailing spaces. 130
Error Line has trailing spaces. 134

org/apache/torque/avalon/TorqueComponent.java

Error Line
Error Line has trailing spaces. 164
Error Line has trailing spaces. 166
Error Line has trailing spaces. 168
Error Line has trailing spaces. 170
Error 'cast' is not followed by whitespace. 174
Error Line has trailing spaces. 178

org/apache/torque/manager/AbstractBaseManager.java

Error Line
Error Missing a Javadoc comment. 68
Error Missing a Javadoc comment. 70
Error Missing a Javadoc comment. 72
Error Missing a Javadoc comment. 74
Error Missing a Javadoc comment. 75
Error The double-checked locking idiom is broken and should be avoided. 498
Error 'isNew' hides a field. 536
Error Must have at least one statement. 543

org/apache/torque/manager/MethodCacheKey.java

Error Line
Error Missing a Javadoc comment. 37
Error Variable 'n' must be private and have accessor methods. 37
Error Missing a Javadoc comment. 38
Error Missing a Javadoc comment. 39
Error Missing a Javadoc comment. 40
Error Missing a Javadoc comment. 41
Error Missing a Javadoc comment. 42
Error Missing a Javadoc comment. 43
Error Missing a Javadoc comment. 44
Error '3' is a magic number. 143
Error '3' is a magic number. 167
Error '4' is a magic number. 170
Error '3' is a magic number. 171
Error '3' is a magic number. 203
Error '5' is a magic number. 205
Error '3' is a magic number. 232
Error '5' is a magic number. 234
Error '50' is a magic number. 248
Error '3' is a magic number. 261
Error '5' is a magic number. 263
Error Missing a Javadoc comment. 277

org/apache/torque/manager/MethodResultCache.java

Error Line
Error Missing a Javadoc comment. 46
Error Missing a Javadoc comment. 47
Error Missing a Javadoc comment. 48
Error '10000' is a magic number. 58

org/apache/torque/map/DatabaseMap.java

Error Line
Error '3' is a magic number. 446

org/apache/torque/oid/IDBroker.java

Error Line
Error '100' is a magic number. 493
Error Must have at least one statement. 542
Error 'cast' is not followed by whitespace. 747
Error '10' is a magic number. 775
Error 'cast' is not followed by whitespace. 775
Error '50' is a magic number. 866
Error '50' is a magic number. 913

org/apache/torque/oid/IDGeneratorFactory.java

Error Line
Error Class IDGeneratorFactory should be declared as final. 32

org/apache/torque/om/DateKey.java

Error Line
Error Definition of 'equals()' without corresponding definition of 'hashCode()'. 130

org/apache/torque/om/NumberKey.java

Error Line
Error Redundant throws: 'NumberFormatException' is unchecked exception. 142

org/apache/torque/om/StringKey.java

Error Line
Error Definition of 'equals()' without corresponding definition of 'hashCode()'. 117

org/apache/torque/util/BasePeer.java

Error Line
Error Utility classes should not have a public or default constructor. 78

org/apache/torque/util/CountHelper.java

Error Line
Error Missing a Javadoc comment. 39

org/apache/torque/util/Criteria.java

Error Line
Error File length is 3.857 lines (max allowed is 2.000). 1
Error Missing a Javadoc comment. 152
Error Missing a Javadoc comment. 154
Error Missing a Javadoc comment. 155
Error Missing a Javadoc comment. 156
Error Missing a Javadoc comment. 157
Error Missing a Javadoc comment. 158
Error Missing a Javadoc comment. 159
Error Missing a Javadoc comment. 160
Error Missing a Javadoc comment. 161
Error Missing a Javadoc comment. 162
Error Missing a Javadoc comment. 163
Error '3' is a magic number. 163
Error Missing a Javadoc comment. 180
Error '8' is a magic number. 180
Error Missing a Javadoc comment. 182
Error '16' is a magic number. 1869
Error '37' is a magic number. 1870
Error '37' is a magic number. 1871
Error '37' is a magic number. 1872
Error '37' is a magic number. 1873
Error '37' is a magic number. 1874
Error '37' is a magic number. 1875
Error '37' is a magic number. 1876
Error '37' is a magic number. 1877
Error '37' is a magic number. 1878
Error '37' is a magic number. 1879
Error '37' is a magic number. 1880
Error '37' is a magic number. 1881
Error '37' is a magic number. 1882
Error '3' is a magic number. 3060
Error '3' is a magic number. 3097
Error Line has trailing spaces. 3098
Error 'joins' hides a field. 3099
Error Missing a Javadoc comment. 3127
Error Missing a Javadoc comment. 3128
Error Missing a Javadoc comment. 3155
Error 'db' hides a field. 3297
Error 'db' hides a field. 3464
Error '25' is a magic number. 3579
Error '13' is a magic number. 3849
Error '37' is a magic number. 3850
Error '37' is a magic number. 3851
Error '37' is a magic number. 3852

org/apache/torque/util/LargeSelect.java

Error Line
Error '{' is followed by whitespace. 365
Error '{' is followed by whitespace. 368
Error '{' is followed by whitespace. 396
Error '{' is followed by whitespace. 666
Error Method length is 216 lines (max allowed is 150). 685
Error Line has trailing spaces. 744
Error Line has trailing spaces. 751

org/apache/torque/util/Query.java

Error Line
Error Missing a Javadoc comment. 41
Error Missing a Javadoc comment. 42
Error Missing a Javadoc comment. 43
Error Missing a Javadoc comment. 44
Error Missing a Javadoc comment. 45
Error Missing a Javadoc comment. 46
Error Missing a Javadoc comment. 47
Error Missing a Javadoc comment. 48
Error Missing a Javadoc comment. 49
Error Missing a Javadoc comment. 50
Error Missing a Javadoc comment. 52
Error Missing a Javadoc comment. 53
Error Missing a Javadoc comment. 54
Error Missing a Javadoc comment. 55
Error Missing a Javadoc comment. 56
Error Missing a Javadoc comment. 57
Error Missing a Javadoc comment. 58
Error Missing a Javadoc comment. 59
Error Missing a Javadoc comment. 60
Error Missing a Javadoc comment. 61
Error Missing a Javadoc comment. 62
Error Missing a Javadoc comment. 63
Error Line has trailing spaces. 218
Error Line has trailing spaces. 284

org/apache/torque/util/SQLBuilder.java

Error Line
Error Missing a Javadoc comment. 54
Error '4' is a magic number. 256

org/apache/torque/util/SqlEnum.java

Error Line
Error Class SqlEnum should be declared as final. 32
Error Missing a Javadoc comment. 39
Error Missing a Javadoc comment. 51
Error Missing a Javadoc comment. 53
Error Missing a Javadoc comment. 55
Error Missing a Javadoc comment. 57
Error Missing a Javadoc comment. 59
Error Missing a Javadoc comment. 61
Error Missing a Javadoc comment. 63
Error Missing a Javadoc comment. 65
Error Missing a Javadoc comment. 67
Error Missing a Javadoc comment. 69
Error Missing a Javadoc comment. 71
Error Missing a Javadoc comment. 73
Error Missing a Javadoc comment. 75
Error Missing a Javadoc comment. 77
Error Missing a Javadoc comment. 79
Error Missing a Javadoc comment. 81
Error Missing a Javadoc comment. 83
Error Missing a Javadoc comment. 85
Error Missing a Javadoc comment. 87
Error Missing a Javadoc comment. 89
Error Missing a Javadoc comment. 91
Error Missing a Javadoc comment. 93
Error Missing a Javadoc comment. 95
Error Missing a Javadoc comment. 97
Error Missing a Javadoc comment. 99
Error Missing a Javadoc comment. 101
Error Missing a Javadoc comment. 103
Error Missing a Javadoc comment. 105
Error Missing a Javadoc comment. 107

org/apache/torque/util/SqlExpression.java

Error Line
Error '25' is a magic number. 100
Error '40' is a magic number. 184
Error '20' is a magic number. 184
Error Method length is 151 lines (max allowed is 150). 388
Error switch without "default" clause. 410
Error '1.1' is a magic number. 682

org/apache/torque/util/Transaction.java

Error Line
Error Expression can be simplified. 145
Error Expression can be simplified. 185

org/apache/torque/util/VillageUtils.java

Error Line
Error Redundant 'final' modifier. 67
Error Redundant 'final' modifier. 89
Error Redundant 'final' modifier. 111
Error Redundant 'final' modifier. 134
Error Redundant 'final' modifier. 184