Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
| Files |
Infos |
Warnings |
Errors |
| 146 |
0 |
0 |
2395 |
Files
org/apache/torque/NoRowsException.java
| Error |
Line |
|
Parameter msg should be final. |
81
|
|
Parameter nested should be final. |
93
|
|
Parameter msg should be final. |
106
|
|
Parameter nested should be final. |
106
|
org/apache/torque/TooManyRowsException.java
| Error |
Line |
|
Parameter msg should be final. |
80
|
|
Parameter nested should be final. |
92
|
|
Parameter msg should be final. |
105
|
|
Parameter nested should be final. |
105
|
org/apache/torque/Torque.java
| Error |
Line |
|
Line has trailing spaces. |
121
|
|
Name 'memberConfig' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
125
|
|
Parameter configFile should be final. |
158
|
|
Parameter conf should be final. |
171
|
|
Parameter conf should be final. |
192
|
|
Parameter name should be final. |
213
|
|
Parameter name should be final. |
226
|
|
Parameter defaultClassName should be final. |
227
|
|
Parameter name should be final. |
266
|
|
Parameter className should be final. |
277
|
|
Parameter name should be final. |
303
|
|
Parameter name should be final. |
321
|
|
Parameter username should be final. |
321
|
|
Parameter password should be final. |
322
|
|
Parameter name should be final. |
335
|
|
Parameter con should be final. |
355
|
|
Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
376
|
|
Parameter conf should be final. |
376
|
|
Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
388
|
|
Method 'dispose' is not designed for extension - needs to be abstract, final or empty. |
397
|
org/apache/torque/TorqueException.java
| Error |
Line |
|
Parameter msg should be final. |
83
|
|
Parameter nested should be final. |
95
|
|
Parameter msg should be final. |
108
|
|
Parameter nested should be final. |
108
|
org/apache/torque/TorqueInstance.java
| Error |
Line |
|
Name 'defaultDBName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
108
|
|
Name 'dbMaps' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
111
|
|
Name 'dsFactoryMap' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
114
|
|
Name 'adapterMap' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
117
|
|
Name 'managers' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
120
|
|
Name 'conf' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
123
|
|
Name 'isInit' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
126
|
|
Name 'mapBuilders' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
134
|
|
Redundant 'final' modifier. |
207
|
|
Parameter conf should be final. |
207
|
|
'conf' hides a field. |
207
|
|
';' is followed by whitespace. |
220
|
|
Line is longer than 80 characters. |
230
|
|
Parameter conf should be final. |
260
|
|
'conf' hides a field. |
260
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
332
|
|
Parameter configFile should be final. |
332
|
|
'conf' hides a field. |
338
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
357
|
|
Parameter conf should be final. |
357
|
|
'conf' hides a field. |
357
|
|
Method 'initManagerMappings' is not designed for extension - needs to be abstract, final or empty. |
388
|
|
Parameter conf should be final. |
388
|
|
'conf' hides a field. |
388
|
|
Parameter name should be final. |
434
|
|
Parameter className should be final. |
434
|
|
Method 'isInit' is not designed for extension - needs to be abstract, final or empty. |
464
|
|
Method 'setConfiguration' is not designed for extension - needs to be abstract, final or empty. |
474
|
|
Parameter conf should be final. |
474
|
|
'conf' hides a field. |
474
|
|
Method 'getConfiguration' is not designed for extension - needs to be abstract, final or empty. |
485
|
|
Method 'getManager' is not designed for extension - needs to be abstract, final or empty. |
497
|
|
Parameter name should be final. |
497
|
|
Method 'getManager' is not designed for extension - needs to be abstract, final or empty. |
515
|
|
Parameter name should be final. |
515
|
|
Parameter defaultClassName should be final. |
516
|
|
Method 'shutdown' is not designed for extension - needs to be abstract, final or empty. |
546
|
|
Method 'getDatabaseMap' is not designed for extension - needs to be abstract, final or empty. |
581
|
|
Method 'getDatabaseMap' is not designed for extension - needs to be abstract, final or empty. |
597
|
|
Parameter name should be final. |
597
|
|
Redundant 'final' modifier. |
631
|
|
Parameter name should be final. |
631
|
|
Method 'registerMapBuilder' is not designed for extension - needs to be abstract, final or empty. |
674
|
|
Parameter className should be final. |
674
|
|
Parameter db should be final. |
687
|
|
Parameter prop should be final. |
687
|
|
Redundant 'final' modifier. |
705
|
|
Parameter map should be final. |
705
|
|
Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
722
|
|
Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
735
|
|
Parameter name should be final. |
735
|
|
Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
773
|
|
Parameter name should be final. |
773
|
|
Parameter username should be final. |
773
|
|
Parameter password should be final. |
774
|
|
Method 'getDB' is not designed for extension - needs to be abstract, final or empty. |
808
|
|
Parameter name should be final. |
808
|
|
Method 'getDefaultDB' is not designed for extension - needs to be abstract, final or empty. |
820
|
|
Line has trailing spaces. |
830
|
|
Method 'closeConnection' is not designed for extension - needs to be abstract, final or empty. |
842
|
|
Parameter con should be final. |
842
|
org/apache/torque/TorqueRuntimeException.java
| Error |
Line |
|
Name 'nested' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
87
|
|
Parameter msg should be final. |
104
|
|
Parameter nested should be final. |
116
|
|
'nested' hides a field. |
116
|
|
Parameter msg should be final. |
130
|
|
Parameter nested should be final. |
130
|
|
'nested' hides a field. |
130
|
|
Method 'printStackTrace' is not designed for extension - needs to be abstract, final or empty. |
139
|
|
Method 'printStackTrace' is not designed for extension - needs to be abstract, final or empty. |
152
|
|
Parameter out should be final. |
152
|
|
Method 'printStackTrace' is not designed for extension - needs to be abstract, final or empty. |
168
|
|
Parameter out should be final. |
168
|
|
Method 'printStackTrace' is not designed for extension - needs to be abstract, final or empty. |
183
|
|
Parameter out should be final. |
183
|
|
Parameter skip should be final. |
183
|
|
Parameter t should be final. |
232
|
|
Parameter stackTrace should be final. |
246
|
org/apache/torque/adapter/DB.java
| Error |
Line |
|
Parameter in should be final. |
123
|
|
Method 'getStringDelimiter' is not designed for extension - needs to be abstract, final or empty. |
132
|
|
Parameter obj should be final. |
154
|
|
Parameter con should be final. |
163
|
|
Parameter table should be final. |
163
|
|
Parameter con should be final. |
173
|
|
Parameter table should be final. |
173
|
|
Parameter in should be final. |
182
|
|
Method 'ignoreCaseInOrderBy' is not designed for extension - needs to be abstract, final or empty. |
193
|
|
Parameter in should be final. |
193
|
|
Method 'supportsNativeLimit' is not designed for extension - needs to be abstract, final or empty. |
205
|
|
Method 'supportsNativeOffset' is not designed for extension - needs to be abstract, final or empty. |
218
|
|
Method 'escapeText' is not designed for extension - needs to be abstract, final or empty. |
231
|
|
Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
242
|
|
Method 'getDateString' is not designed for extension - needs to be abstract, final or empty. |
254
|
|
Parameter date should be final. |
254
|
|
Method 'getBooleanString' is not designed for extension - needs to be abstract, final or empty. |
275
|
|
Parameter b should be final. |
275
|
|
Avoid inline conditionals. |
277
|
org/apache/torque/adapter/DBAxion.java
| Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
83
|
|
Parameter in should be final. |
83
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
94
|
|
Parameter in should be final. |
94
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
102
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
110
|
|
Parameter obj should be final. |
110
|
|
Parameter con should be final. |
122
|
|
Parameter table should be final. |
122
|
|
Parameter con should be final. |
133
|
|
Parameter table should be final. |
133
|
org/apache/torque/adapter/DBCloudscape.java
| Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
84
|
|
Parameter in should be final. |
84
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
95
|
|
Parameter in should be final. |
95
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
103
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
111
|
|
Parameter obj should be final. |
111
|
|
'132' is a magic number. |
113
|
|
'3' is a magic number. |
140
|
|
Parameter con should be final. |
170
|
|
Parameter table should be final. |
170
|
|
Parameter con should be final. |
181
|
|
Parameter table should be final. |
181
|
org/apache/torque/adapter/DBDB2400.java
| Error |
Line |
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
85
|
|
Parameter in should be final. |
85
|
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
97
|
|
Parameter in should be final. |
97
|
|
Parameter in should be final. |
110
|
org/apache/torque/adapter/DBDB2App.java
| Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
86
|
|
Parameter in should be final. |
86
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
98
|
|
Parameter in should be final. |
98
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
107
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
115
|
|
Parameter obj should be final. |
115
|
|
Parameter con should be final. |
127
|
|
Parameter table should be final. |
127
|
|
Parameter con should be final. |
138
|
|
Parameter table should be final. |
138
|
org/apache/torque/adapter/DBDB2Net.java
| Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
87
|
|
Parameter in should be final. |
87
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
99
|
|
Parameter in should be final. |
99
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
108
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
116
|
|
Parameter obj should be final. |
116
|
|
Parameter con should be final. |
128
|
|
Parameter table should be final. |
128
|
|
Parameter con should be final. |
139
|
|
Parameter table should be final. |
139
|
org/apache/torque/adapter/DBFactory.java
| Error |
Line |
|
Utility classes should not have a public or default constructor. |
71
|
|
'40' is a magic number. |
76
|
|
Parameter driver should be final. |
138
|
org/apache/torque/adapter/DBHypersonicSQL.java
| Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
84
|
|
Parameter in should be final. |
84
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
95
|
|
Parameter in should be final. |
95
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
103
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
111
|
|
Parameter obj should be final. |
111
|
|
Parameter con should be final. |
126
|
|
Parameter table should be final. |
126
|
|
Parameter con should be final. |
137
|
|
Parameter table should be final. |
137
|
org/apache/torque/adapter/DBInformix.java
| Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
85
|
|
Parameter in should be final. |
85
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
98
|
|
Parameter in should be final. |
98
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
106
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
114
|
|
Parameter obj should be final. |
114
|
|
Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
126
|
|
Parameter con should be final. |
126
|
|
Parameter table should be final. |
126
|
|
Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
145
|
|
Parameter con should be final. |
145
|
|
Parameter table should be final. |
145
|
org/apache/torque/adapter/DBInstantDB.java
| Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
87
|
|
Parameter in should be final. |
87
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
98
|
|
Parameter in should be final. |
98
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
106
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
114
|
|
Parameter obj should be final. |
114
|
|
Parameter con should be final. |
126
|
|
Parameter table should be final. |
126
|
|
Parameter con should be final. |
137
|
|
Parameter table should be final. |
137
|
org/apache/torque/adapter/DBInterbase.java
| Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
75
|
|
Parameter in should be final. |
75
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
86
|
|
Parameter in should be final. |
86
|
|
Method 'ignoreCaseInOrderBy' is not designed for extension - needs to be abstract, final or empty. |
100
|
|
Parameter in should be final. |
100
|
|
Method 'getStringDelimiter' is not designed for extension - needs to be abstract, final or empty. |
110
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
118
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
126
|
|
Parameter obj should be final. |
126
|
|
Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
138
|
|
Parameter con should be final. |
138
|
|
Parameter table should be final. |
138
|
|
Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
160
|
|
Parameter con should be final. |
160
|
|
Parameter table should be final. |
160
|
org/apache/torque/adapter/DBMM.java
| Error |
Line |
|
Line has trailing spaces. |
81
|
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
98
|
|
Parameter in should be final. |
98
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
109
|
|
Parameter in should be final. |
109
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
117
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
129
|
|
Parameter obj should be final. |
129
|
|
Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
142
|
|
Parameter con should be final. |
142
|
|
Parameter table should be final. |
142
|
|
Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
158
|
|
Parameter con should be final. |
158
|
|
Parameter table should be final. |
158
|
|
Method 'supportsNativeLimit' is not designed for extension - needs to be abstract, final or empty. |
170
|
|
Method 'supportsNativeOffset' is not designed for extension - needs to be abstract, final or empty. |
182
|
|
Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
193
|
|
Method 'getDateString' is not designed for extension - needs to be abstract, final or empty. |
206
|
|
Parameter date should be final. |
206
|
org/apache/torque/adapter/DBMSSQL.java
| Error |
Line |
|
Method 'supportsNativeLimit' is not designed for extension - needs to be abstract, final or empty. |
83
|
org/apache/torque/adapter/DBNone.java
| Error |
Line |
|
Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
81
|
|
Parameter url should be final. |
90
|
|
Expected @param tag for 'url'. |
90
|
|
Parameter username should be final. |
90
|
|
Expected @param tag for 'username'. |
90
|
|
Parameter password should be final. |
90
|
|
Expected @param tag for 'password'. |
90
|
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
100
|
|
Parameter in should be final. |
100
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
111
|
|
Parameter in should be final. |
111
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
119
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
127
|
|
Parameter obj should be final. |
127
|
|
Parameter con should be final. |
139
|
|
Parameter table should be final. |
139
|
|
Parameter con should be final. |
150
|
|
Parameter table should be final. |
150
|
org/apache/torque/adapter/DBOdbc.java
| Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
83
|
|
Parameter in should be final. |
83
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
94
|
|
Parameter in should be final. |
94
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
102
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
110
|
|
Parameter obj should be final. |
110
|
|
Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
124
|
|
Parameter con should be final. |
124
|
|
Parameter table should be final. |
124
|
|
Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
138
|
|
Parameter con should be final. |
138
|
|
Parameter table should be final. |
138
|
org/apache/torque/adapter/DBOracle.java
| Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
90
|
|
Parameter in should be final. |
90
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
101
|
|
Parameter in should be final. |
101
|
|
Line has trailing spaces. |
112
|
|
Method 'getDateString' is not designed for extension - needs to be abstract, final or empty. |
112
|
|
Parameter date should be final. |
112
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
121
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
139
|
|
Parameter sequenceName should be final. |
139
|
|
Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
151
|
|
Parameter con should be final. |
151
|
|
Parameter table should be final. |
151
|
|
Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
170
|
|
Parameter con should be final. |
170
|
|
Parameter table should be final. |
170
|
|
Method 'supportsNativeLimit' is not designed for extension - needs to be abstract, final or empty. |
183
|
|
Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
194
|
|
Method 'escapeText' is not designed for extension - needs to be abstract, final or empty. |
206
|
org/apache/torque/adapter/DBPostgres.java
| Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
83
|
|
Parameter in should be final. |
83
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
95
|
|
Parameter in should be final. |
95
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
104
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
115
|
|
Parameter name should be final. |
115
|
|
Parameter con should be final. |
127
|
|
Parameter table should be final. |
127
|
|
Parameter con should be final. |
138
|
|
Parameter table should be final. |
138
|
|
Method 'supportsNativeLimit' is not designed for extension - needs to be abstract, final or empty. |
148
|
|
Method 'supportsNativeOffset' is not designed for extension - needs to be abstract, final or empty. |
160
|
|
Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
171
|
|
Method 'getBooleanString' is not designed for extension - needs to be abstract, final or empty. |
181
|
|
Parameter b should be final. |
181
|
|
Avoid inline conditionals. |
183
|
|
Avoid inline conditionals. |
183
|
org/apache/torque/adapter/DBSapDB.java
| Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
84
|
|
Parameter in should be final. |
84
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
95
|
|
Parameter in should be final. |
95
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
103
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
121
|
|
Parameter sequenceName should be final. |
121
|
|
Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
133
|
|
Parameter con should be final. |
133
|
|
Parameter table should be final. |
133
|
|
Method 'escapeText' is not designed for extension - needs to be abstract, final or empty. |
153
|
|
Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
166
|
|
Parameter con should be final. |
166
|
|
Parameter table should be final. |
166
|
org/apache/torque/adapter/DBSybase.java
| Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
92
|
|
Parameter in should be final. |
92
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
103
|
|
Parameter in should be final. |
103
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
111
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
123
|
|
Parameter unused should be final. |
123
|
|
Method 'lockTable' is not designed for extension - needs to be abstract, final or empty. |
135
|
|
Parameter con should be final. |
135
|
|
Parameter table should be final. |
135
|
|
Method 'unlockTable' is not designed for extension - needs to be abstract, final or empty. |
154
|
|
Parameter con should be final. |
154
|
|
Parameter table should be final. |
154
|
|
Method 'supportsNativeLimit' is not designed for extension - needs to be abstract, final or empty. |
167
|
|
Method 'getLimitStyle' is not designed for extension - needs to be abstract, final or empty. |
178
|
|
Method 'getDateString' is not designed for extension - needs to be abstract, final or empty. |
191
|
|
Parameter date should be final. |
191
|
org/apache/torque/adapter/DBWeblogic.java
| Error |
Line |
|
Method 'toUpperCase' is not designed for extension - needs to be abstract, final or empty. |
82
|
|
Parameter in should be final. |
82
|
|
Method 'ignoreCase' is not designed for extension - needs to be abstract, final or empty. |
93
|
|
Parameter in should be final. |
93
|
|
Method 'getIDMethodType' is not designed for extension - needs to be abstract, final or empty. |
101
|
|
Method 'getIDMethodSQL' is not designed for extension - needs to be abstract, final or empty. |
109
|
|
Parameter obj should be final. |
109
|
|
Parameter con should be final. |
121
|
|
Parameter table should be final. |
121
|
|
Parameter con should be final. |
132
|
|
Parameter table should be final. |
132
|
org/apache/torque/adapter/IDMethod.java
| Error |
Line |
|
interfaces should describe a type and hence have methods. |
64
|
org/apache/torque/avalon/Torque.java
| Error |
Line |
|
Line does not match expected header line of '/* ===================================================================='. |
3
|
|
interfaces should describe a type and hence have methods. |
66
|
|
Missing a Javadoc comment. |
69
|
org/apache/torque/avalon/TorqueComponent.java
| Error |
Line |
|
Name 'context' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
96
|
|
Name 'torqueInstance' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
99
|
|
Name 'configFile' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
102
|
|
Line is longer than 80 characters. |
111
|
|
Parameter torqueInstance should be final. |
124
|
|
'torqueInstance' hides a field. |
124
|
|
Line is longer than 80 characters. |
146
|
|
Method 'configure' is not designed for extension - needs to be abstract, final or empty. |
148
|
|
Parameter configuration should be final. |
148
|
|
'configFile' hides a field. |
153
|
|
Line has trailing spaces. |
158
|
|
Avoid inline conditionals. |
159
|
|
Line has trailing spaces. |
179
|
|
Line has trailing spaces. |
184
|
|
Method 'contextualize' is not designed for extension - needs to be abstract, final or empty. |
196
|
|
Parameter context should be final. |
196
|
|
'context' hides a field. |
196
|
|
Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
205
|
|
Method 'start' is not designed for extension - needs to be abstract, final or empty. |
215
|
|
Method 'stop' is not designed for extension - needs to be abstract, final or empty. |
223
|
|
Method 'isInit' is not designed for extension - needs to be abstract, final or empty. |
243
|
|
Method 'getConfiguration' is not designed for extension - needs to be abstract, final or empty. |
253
|
|
Method 'getManager' is not designed for extension - needs to be abstract, final or empty. |
264
|
|
Parameter name should be final. |
264
|
|
Method 'getManager' is not designed for extension - needs to be abstract, final or empty. |
277
|
|
Parameter name should be final. |
277
|
|
Parameter defaultClassName should be final. |
278
|
|
Method 'getDatabaseMap' is not designed for extension - needs to be abstract, final or empty. |
290
|
|
Method 'getDatabaseMap' is not designed for extension - needs to be abstract, final or empty. |
306
|
|
Parameter name should be final. |
306
|
|
Method 'registerMapBuilder' is not designed for extension - needs to be abstract, final or empty. |
317
|
|
Parameter className should be final. |
317
|
|
Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
329
|
|
Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
342
|
|
Parameter name should be final. |
342
|
|
Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
360
|
|
Parameter name should be final. |
360
|
|
Parameter username should be final. |
360
|
|
Parameter password should be final. |
361
|
|
Method 'getDB' is not designed for extension - needs to be abstract, final or empty. |
374
|
|
Parameter name should be final. |
374
|
|
Method 'getDefaultDB' is not designed for extension - needs to be abstract, final or empty. |
385
|
|
Method 'closeConnection' is not designed for extension - needs to be abstract, final or empty. |
395
|
|
Parameter con should be final. |
395
|
org/apache/torque/dsfactory/AbstractDataSourceFactory.java
| Error |
Line |
|
Method 'setProperty' is not designed for extension - needs to be abstract, final or empty. |
108
|
|
Parameter property should be final. |
108
|
|
Parameter c should be final. |
108
|
|
Parameter ds should be final. |
108
|
|
Method 'applyConfiguration' is not designed for extension - needs to be abstract, final or empty. |
184
|
|
Parameter c should be final. |
184
|
|
Parameter o should be final. |
184
|
|
Line has trailing spaces. |
206
|
|
Method 'initCPDS' is not designed for extension - needs to be abstract, final or empty. |
214
|
|
Parameter configuration should be final. |
214
|
|
Line has trailing spaces. |
231
|
|
Line has trailing spaces. |
234
|
org/apache/torque/dsfactory/DataSourceFactory.java
| Error |
Line |
|
Line has trailing spaces. |
69
|
|
Line has trailing spaces. |
83
|
org/apache/torque/dsfactory/JndiDataSourceFactory.java
| Error |
Line |
|
Name 'path' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
92
|
|
Name 'ctx' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
94
|
|
Method 'getDataSource' is not designed for extension - needs to be abstract, final or empty. |
99
|
|
Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
116
|
|
Parameter configuration should be final. |
116
|
|
Parameter configuration should be final. |
135
|
|
Parameter configuration should be final. |
192
|
|
Parameter ctx should be final. |
236
|
|
'ctx' hides a field. |
236
|
|
Expected @throws tag for 'NamingException'. |
236
|
|
Parameter ctx should be final. |
257
|
|
'ctx' hides a field. |
257
|
|
Expected @param tag for 'ctx'. |
257
|
|
Parameter path should be final. |
257
|
|
'path' hides a field. |
257
|
|
Expected @param tag for 'path'. |
257
|
|
Parameter ds should be final. |
257
|
|
Expected @param tag for 'ds'. |
257
|
|
Expected @throws tag for 'Exception'. |
258
|
|
Must have at least one statement. |
280
|
|
Must have at least one statement. |
284
|
org/apache/torque/dsfactory/PerUserPoolDataSourceFactory.java
| Error |
Line |
|
Line has trailing spaces. |
83
|
|
Name 'ds' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
87
|
|
Method 'getDataSource' is not designed for extension - needs to be abstract, final or empty. |
92
|
|
Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
100
|
|
Parameter configuration should be final. |
100
|
|
'ds' hides a field. |
110
|
|
Parameter configuration should be final. |
122
|
|
'ds' hides a field. |
126
|
org/apache/torque/dsfactory/SharedPoolDataSourceFactory.java
| Error |
Line |
|
Line has trailing spaces. |
83
|
|
Name 'ds' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
87
|
|
Method 'getDataSource' is not designed for extension - needs to be abstract, final or empty. |
92
|
|
Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
100
|
|
Parameter configuration should be final. |
100
|
|
'ds' hides a field. |
110
|
|
Parameter configuration should be final. |
122
|
|
'ds' hides a field. |
126
|
org/apache/torque/dsfactory/TorqueDataSourceFactory.java
| Error |
Line |
|
Name 'ds' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
86
|
|
Method 'getDataSource' is not designed for extension - needs to be abstract, final or empty. |
91
|
|
Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
99
|
|
Parameter configuration should be final. |
99
|
|
Method 'initTorqueClassic' is not designed for extension - needs to be abstract, final or empty. |
121
|
|
Parameter configuration should be final. |
122
|
|
'ds' hides a field. |
126
|
org/apache/torque/manager/AbstractBaseManager.java
| Error |
Line |
|
Variable 'log' must be private and have accessor methods. |
92
|
|
Name 'cache' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
95
|
|
Variable 'cache' must be private and have accessor methods. |
95
|
|
Name 'mrCache' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
98
|
|
Variable 'mrCache' must be private and have accessor methods. |
98
|
|
Name 'omClass' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
101
|
|
Missing a Javadoc comment. |
103
|
|
Name 'className' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
103
|
|
Missing a Javadoc comment. |
105
|
|
Name 'region' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
105
|
|
Missing a Javadoc comment. |
107
|
|
Name 'isNew' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
107
|
|
Missing a Javadoc comment. |
109
|
|
Name 'validFields' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
109
|
|
Variable 'validFields' must be private and have accessor methods. |
109
|
|
Missing a Javadoc comment. |
110
|
|
Name 'listenersMap' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
110
|
|
Variable 'listenersMap' must be private and have accessor methods. |
110
|
|
Method 'getOMClass' is not designed for extension - needs to be abstract, final or empty. |
117
|
|
Method 'setOMClass' is not designed for extension - needs to be abstract, final or empty. |
127
|
|
Parameter omClass should be final. |
127
|
|
'omClass' hides a field. |
127
|
|
Method 'getOMInstance' is not designed for extension - needs to be abstract, final or empty. |
139
|
|
Expected @throws tag for 'InstantiationException'. |
140
|
|
Expected @throws tag for 'IllegalAccessException'. |
140
|
|
Method 'getClassName' is not designed for extension - needs to be abstract, final or empty. |
149
|
|
Method 'setClassName' is not designed for extension - needs to be abstract, final or empty. |
160
|
|
Parameter v should be final. |
160
|
|
Expected an @return tag. |
183
|
|
Method 'getOMInstance' is not designed for extension - needs to be abstract, final or empty. |
183
|
|
Parameter id should be final. |
183
|
|
Expected @param tag for 'id'. |
183
|
|
Expected an @return tag. |
195
|
|
Method 'getOMInstance' is not designed for extension - needs to be abstract, final or empty. |
195
|
|
Parameter key should be final. |
195
|
|
Expected @param tag for 'key'. |
195
|
|
Parameter fromCache should be final. |
195
|
|
Expected @param tag for 'fromCache'. |
195
|
|
Method 'cacheGet' is not designed for extension - needs to be abstract, final or empty. |
216
|
|
Missing a Javadoc comment. |
216
|
|
Parameter key should be final. |
216
|
|
Line has trailing spaces. |
230
|
|
Method 'clearImpl' is not designed for extension - needs to be abstract, final or empty. |
234
|
|
Line has trailing spaces. |
252
|
|
Expected an @return tag. |
258
|
|
Method 'removeInstanceImpl' is not designed for extension - needs to be abstract, final or empty. |
258
|
|
Parameter key should be final. |
258
|
|
Expected @param tag for 'key'. |
258
|
|
Line has trailing spaces. |
283
|
|
Expected an @return tag. |
289
|
|
Method 'putInstanceImpl' is not designed for extension - needs to be abstract, final or empty. |
289
|
|
Parameter om should be final. |
289
|
|
Expected @param tag for 'om'. |
289
|
|
Line has trailing spaces. |
297
|
|
Expected an @return tag. |
304
|
|
Method 'putInstanceImpl' is not designed for extension - needs to be abstract, final or empty. |
304
|
|
Parameter key should be final. |
304
|
|
Expected @param tag for 'key'. |
304
|
|
Parameter om should be final. |
304
|
|
Expected @param tag for 'om'. |
304
|
|
Line has trailing spaces. |
335
|
|
Expected an @return tag. |
341
|
|
Parameter id should be final. |
341
|
|
Expected @param tag for 'id'. |
341
|
|
Method 'getOMs' is not designed for extension - needs to be abstract, final or empty. |
352
|
|
Parameter ids should be final. |
352
|
|
Method 'getOMs' is not designed for extension - needs to be abstract, final or empty. |
366
|
|
Parameter ids should be final. |
366
|
|
Method 'getOMs' is not designed for extension - needs to be abstract, final or empty. |
380
|
|
Parameter ids should be final. |
380
|
|
Parameter fromCache should be final. |
380
|
|
Expected @param tag for 'fromCache'. |
380
|
|
Line has trailing spaces. |
438
|
|
Expected an @return tag. |
444
|
|
Parameter ids should be final. |
444
|
|
Expected @param tag for 'ids'. |
444
|
|
Line has trailing spaces. |
449
|
|
Method 'getRegion' is not designed for extension - needs to be abstract, final or empty. |
452
|
|
Method 'setRegion' is not designed for extension - needs to be abstract, final or empty. |
464
|
|
Parameter v should be final. |
464
|
|
Method 'getMethodResultCache' is not designed for extension - needs to be abstract, final or empty. |
493
|
|
The double-checked locking idiom is broken and should be avoided. |
499
|
|
Line has trailing spaces. |
518
|
|
Method 'addCacheListenerImpl' is not designed for extension - needs to be abstract, final or empty. |
521
|
|
Parameter listener should be final. |
521
|
|
'isNew' hides a field. |
537
|
|
Must have at least one statement. |
544
|
|
Line has trailing spaces. |
565
|
|
Parameter key should be final. |
569
|
|
Expected @param tag for 'key'. |
569
|
|
Line has trailing spaces. |
586
|
|
Method 'notifyListeners' is not designed for extension - needs to be abstract, final or empty. |
591
|
|
Parameter listeners should be final. |
591
|
|
Expected @param tag for 'listeners'. |
591
|
|
Parameter oldOm should be final. |
592
|
|
Expected @param tag for 'oldOm'. |
592
|
|
Parameter om should be final. |
592
|
|
Expected @param tag for 'om'. |
592
|
|
Line has trailing spaces. |
629
|
|
Parameter out should be final. |
633
|
|
Expected @param tag for 'out'. |
633
|
|
Expected @throws tag for 'IOException'. |
634
|
|
Line has trailing spaces. |
641
|
|
Parameter in should be final. |
646
|
|
Expected @throws tag for 'IOException'. |
647
|
|
Expected @throws tag for 'ClassNotFoundException'. |
647
|
org/apache/torque/manager/CacheListener.java
| Error |
Line |
|
Line has trailing spaces. |
69
|
|
Expected @param tag for 'om'. |
72
|
|
Line has trailing spaces. |
73
|
|
Line has trailing spaces. |
75
|
|
Expected @param tag for 'om'. |
78
|
|
Line has trailing spaces. |
79
|
|
Line has trailing spaces. |
81
|
|
Line has trailing spaces. |
83
|
|
Expected an @return tag. |
85
|
org/apache/torque/manager/MethodCacheKey.java
| Error |
Line |
|
Missing a Javadoc comment. |
62
|
|
Missing a Javadoc comment. |
67
|
|
Name 'n' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
67
|
|
Variable 'n' must be private and have accessor methods. |
67
|
|
Missing a Javadoc comment. |
68
|
|
Name 'instanceOrClass' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
68
|
|
Missing a Javadoc comment. |
69
|
|
Name 'method' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
69
|
|
Missing a Javadoc comment. |
70
|
|
Name 'arg1' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
70
|
|
Missing a Javadoc comment. |
71
|
|
Name 'arg2' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
71
|
|
Missing a Javadoc comment. |
72
|
|
Name 'arg3' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
72
|
|
Missing a Javadoc comment. |
73
|
|
Name 'moreThanThree' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
73
|
|
Missing a Javadoc comment. |
74
|
|
Name 'groupKey' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
74
|
|
Missing a Javadoc comment. |
76
|
|
Missing a Javadoc comment. |
80
|
|
Parameter instanceOrClass should be final. |
80
|
|
'instanceOrClass' hides a field. |
80
|
|
Parameter method should be final. |
80
|
|
'method' hides a field. |
80
|
|
Missing a Javadoc comment. |
85
|
|
Parameter instanceOrClass should be final. |
85
|
|
'instanceOrClass' hides a field. |
85
|
|
Parameter method should be final. |
85
|
|
'method' hides a field. |
85
|
|
Parameter arg1 should be final. |
86
|
|
'arg1' hides a field. |
86
|
|
Missing a Javadoc comment. |
91
|
|
Parameter instanceOrClass should be final. |
91
|
|
'instanceOrClass' hides a field. |
91
|
|
Parameter method should be final. |
91
|
|
'method' hides a field. |
91
|
|
Parameter arg1 should be final. |
92
|
|
'arg1' hides a field. |
92
|
|
Parameter arg2 should be final. |
92
|
|
'arg2' hides a field. |
92
|
|
Missing a Javadoc comment. |
97
|
|
Parameter instanceOrClass should be final. |
97
|
|
'instanceOrClass' hides a field. |
97
|
|
Parameter method should be final. |
97
|
|
'method' hides a field. |
97
|
|
Parameter arg1 should be final. |
98
|
|
'arg1' hides a field. |
98
|
|
Parameter arg2 should be final. |
98
|
|
'arg2' hides a field. |
98
|
|
Parameter arg3 should be final. |
99
|
|
'arg3' hides a field. |
99
|
|
Missing a Javadoc comment. |
104
|
|
Parameter moreThanThree should be final. |
104
|
|
'moreThanThree' hides a field. |
104
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
116
|
|
Parameter instanceOrClass should be final. |
116
|
|
'instanceOrClass' hides a field. |
116
|
|
Parameter method should be final. |
116
|
|
'method' hides a field. |
116
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
132
|
|
Parameter instanceOrClass should be final. |
132
|
|
'instanceOrClass' hides a field. |
132
|
|
Parameter method should be final. |
132
|
|
'method' hides a field. |
132
|
|
Parameter arg1 should be final. |
133
|
|
'arg1' hides a field. |
133
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
149
|
|
Parameter instanceOrClass should be final. |
149
|
|
'instanceOrClass' hides a field. |
149
|
|
Parameter method should be final. |
149
|
|
'method' hides a field. |
149
|
|
Parameter arg1 should be final. |
150
|
|
'arg1' hides a field. |
150
|
|
Parameter arg2 should be final. |
150
|
|
'arg2' hides a field. |
150
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
168
|
|
Parameter instanceOrClass should be final. |
168
|
|
'instanceOrClass' hides a field. |
168
|
|
Parameter method should be final. |
168
|
|
'method' hides a field. |
168
|
|
Parameter arg1 should be final. |
169
|
|
'arg1' hides a field. |
169
|
|
Parameter arg2 should be final. |
169
|
|
'arg2' hides a field. |
169
|
|
Parameter arg3 should be final. |
170
|
|
'arg3' hides a field. |
170
|
|
Expected @param tag for 'arg3'. |
170
|
|
'3' is a magic number. |
173
|
|
Method 'init' is not designed for extension - needs to be abstract, final or empty. |
188
|
|
Parameter keys should be final. |
188
|
|
'3' is a magic number. |
197
|
|
'4' is a magic number. |
200
|
|
'3' is a magic number. |
201
|
|
Method 'getGroupKey' is not designed for extension - needs to be abstract, final or empty. |
210
|
|
Missing a Javadoc comment. |
210
|
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
215
|
|
Missing a Javadoc comment. |
215
|
|
Parameter obj should be final. |
215
|
|
'3' is a magic number. |
233
|
|
'5' is a magic number. |
235
|
|
Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
249
|
|
Missing a Javadoc comment. |
249
|
|
Avoid inline conditionals. |
255
|
|
Avoid inline conditionals. |
258
|
|
Avoid inline conditionals. |
261
|
|
'3' is a magic number. |
262
|
|
'5' is a magic number. |
264
|
|
Avoid inline conditionals. |
266
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
276
|
|
Missing a Javadoc comment. |
276
|
|
'50' is a magic number. |
278
|
|
'3' is a magic number. |
291
|
|
'5' is a magic number. |
293
|
|
Missing a Javadoc comment. |
307
|
|
Method 'makeObject' is not designed for extension - needs to be abstract, final or empty. |
314
|
|
Expected @throws tag for 'Exception'. |
315
|
|
Method 'passivateObject' is not designed for extension - needs to be abstract, final or empty. |
324
|
|
Parameter obj should be final. |
324
|
|
Expected @throws tag for 'Exception'. |
325
|
org/apache/torque/manager/MethodResultCache.java
| Error |
Line |
|
Missing a Javadoc comment. |
81
|
|
Name 'pool' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
81
|
|
Missing a Javadoc comment. |
82
|
|
Name 'jcsCache' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
82
|
|
Missing a Javadoc comment. |
83
|
|
Name 'groups' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
83
|
|
Missing a Javadoc comment. |
88
|
|
Parameter cache should be final. |
88
|
|
'10000' is a magic number. |
93
|
|
Method 'clear' is not designed for extension - needs to be abstract, final or empty. |
105
|
|
Missing a Javadoc comment. |
105
|
|
Method 'getImpl' is not designed for extension - needs to be abstract, final or empty. |
122
|
|
Missing a Javadoc comment. |
122
|
|
Parameter key should be final. |
122
|
|
Line is longer than 80 characters. |
137
|
|
Method 'putImpl' is not designed for extension - needs to be abstract, final or empty. |
144
|
|
Missing a Javadoc comment. |
144
|
|
Parameter key should be final. |
144
|
|
Parameter value should be final. |
144
|
|
Method 'removeImpl' is not designed for extension - needs to be abstract, final or empty. |
174
|
|
Missing a Javadoc comment. |
174
|
|
Parameter key should be final. |
174
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
190
|
|
Missing a Javadoc comment. |
190
|
|
Parameter instanceOrClass should be final. |
190
|
|
Parameter method should be final. |
190
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
218
|
|
Missing a Javadoc comment. |
218
|
|
Parameter instanceOrClass should be final. |
218
|
|
Parameter method should be final. |
218
|
|
Parameter arg1 should be final. |
219
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
247
|
|
Missing a Javadoc comment. |
247
|
|
Parameter instanceOrClass should be final. |
247
|
|
Parameter method should be final. |
247
|
|
Parameter arg1 should be final. |
248
|
|
Parameter arg2 should be final. |
248
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
276
|
|
Missing a Javadoc comment. |
276
|
|
Parameter instanceOrClass should be final. |
276
|
|
Parameter method should be final. |
276
|
|
Parameter arg1 should be final. |
277
|
|
Parameter arg2 should be final. |
277
|
|
Parameter arg3 should be final. |
278
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
306
|
|
Missing a Javadoc comment. |
306
|
|
Parameter keys should be final. |
306
|
|
Method 'put' is not designed for extension - needs to be abstract, final or empty. |
334
|
|
Missing a Javadoc comment. |
334
|
|
Parameter value should be final. |
334
|
|
Parameter instanceOrClass should be final. |
334
|
|
Parameter method should be final. |
334
|
|
Method 'put' is not designed for extension - needs to be abstract, final or empty. |
348
|
|
Missing a Javadoc comment. |
348
|
|
Parameter value should be final. |
348
|
|
Parameter instanceOrClass should be final. |
348
|
|
Parameter method should be final. |
349
|
|
Parameter arg1 should be final. |
349
|
|
Method 'put' is not designed for extension - needs to be abstract, final or empty. |
363
|
|
Missing a Javadoc comment. |
363
|
|
Parameter value should be final. |
363
|
|
Parameter instanceOrClass should be final. |
363
|
|
Parameter method should be final. |
363
|
|
Parameter arg1 should be final. |
364
|
|
Parameter arg2 should be final. |
364
|
|
Method 'put' is not designed for extension - needs to be abstract, final or empty. |
378
|
|
Missing a Javadoc comment. |
378
|
|
Parameter value should be final. |
378
|
|
Parameter instanceOrClass should be final. |
378
|
|
Parameter method should be final. |
378
|
|
Parameter arg1 should be final. |
379
|
|
Parameter arg2 should be final. |
379
|
|
Parameter arg3 should be final. |
379
|
|
Method 'put' is not designed for extension - needs to be abstract, final or empty. |
393
|
|
Missing a Javadoc comment. |
393
|
|
Parameter value should be final. |
393
|
|
Parameter keys should be final. |
393
|
|
Method 'removeAll' is not designed for extension - needs to be abstract, final or empty. |
408
|
|
Missing a Javadoc comment. |
408
|
|
Parameter instanceOrClass should be final. |
408
|
|
Parameter method should be final. |
408
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
437
|
|
Missing a Javadoc comment. |
437
|
|
Parameter instanceOrClass should be final. |
437
|
|
Parameter method should be final. |
437
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
465
|
|
Missing a Javadoc comment. |
465
|
|
Parameter instanceOrClass should be final. |
465
|
|
Parameter method should be final. |
465
|
|
Parameter arg1 should be final. |
466
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
494
|
|
Missing a Javadoc comment. |
494
|
|
Parameter instanceOrClass should be final. |
494
|
|
Parameter method should be final. |
494
|
|
Parameter arg1 should be final. |
495
|
|
Parameter arg2 should be final. |
495
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
523
|
|
Missing a Javadoc comment. |
523
|
|
Parameter instanceOrClass should be final. |
523
|
|
Parameter method should be final. |
523
|
|
Parameter arg1 should be final. |
524
|
|
Parameter arg2 should be final. |
524
|
|
Parameter arg3 should be final. |
525
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
553
|
|
Missing a Javadoc comment. |
553
|
|
Parameter keys should be final. |
553
|
org/apache/torque/manager/NoOpMethodResultCache.java
| Error |
Line |
|
Missing a Javadoc comment. |
70
|
|
Parameter cache should be final. |
70
|
|
Missing a Javadoc comment. |
76
|
|
Method 'getImpl' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
Missing a Javadoc comment. |
80
|
|
Parameter key should be final. |
80
|
|
Method 'putImpl' is not designed for extension - needs to be abstract, final or empty. |
86
|
|
Missing a Javadoc comment. |
86
|
|
Parameter key should be final. |
86
|
|
Parameter value should be final. |
86
|
|
Method 'removeImpl' is not designed for extension - needs to be abstract, final or empty. |
92
|
|
Missing a Javadoc comment. |
92
|
|
Parameter key should be final. |
92
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
99
|
|
Missing a Javadoc comment. |
99
|
|
Parameter instanceOrClass should be final. |
99
|
|
Parameter method should be final. |
99
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
104
|
|
Missing a Javadoc comment. |
104
|
|
Parameter instanceOrClass should be final. |
104
|
|
Parameter method should be final. |
104
|
|
Parameter arg1 should be final. |
105
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
110
|
|
Missing a Javadoc comment. |
110
|
|
Parameter instanceOrClass should be final. |
110
|
|
Parameter method should be final. |
110
|
|
Parameter arg1 should be final. |
111
|
|
Parameter arg2 should be final. |
111
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
116
|
|
Missing a Javadoc comment. |
116
|
|
Parameter instanceOrClass should be final. |
116
|
|
Parameter method should be final. |
116
|
|
Parameter arg1 should be final. |
117
|
|
Parameter arg2 should be final. |
117
|
|
Parameter arg3 should be final. |
118
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
123
|
|
Missing a Javadoc comment. |
123
|
|
Parameter keys should be final. |
123
|
|
Missing a Javadoc comment. |
128
|
|
Parameter value should be final. |
128
|
|
Parameter instanceOrClass should be final. |
128
|
|
Parameter method should be final. |
128
|
|
Missing a Javadoc comment. |
132
|
|
Parameter value should be final. |
132
|
|
Parameter instanceOrClass should be final. |
132
|
|
Parameter method should be final. |
133
|
|
Parameter arg1 should be final. |
133
|
|
Missing a Javadoc comment. |
137
|
|
Parameter value should be final. |
137
|
|
Parameter instanceOrClass should be final. |
137
|
|
Parameter method should be final. |
137
|
|
Parameter arg1 should be final. |
138
|
|
Parameter arg2 should be final. |
138
|
|
Missing a Javadoc comment. |
142
|
|
Parameter value should be final. |
142
|
|
Parameter instanceOrClass should be final. |
142
|
|
Parameter method should be final. |
142
|
|
Parameter arg1 should be final. |
143
|
|
Parameter arg2 should be final. |
143
|
|
Parameter arg3 should be final. |
143
|
|
Missing a Javadoc comment. |
147
|
|
Parameter value should be final. |
147
|
|
Parameter keys should be final. |
147
|
|
Missing a Javadoc comment. |
152
|
|
Parameter instanceOrClass should be final. |
152
|
|
Parameter method should be final. |
152
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
157
|
|
Missing a Javadoc comment. |
157
|
|
Parameter instanceOrClass should be final. |
157
|
|
Parameter method should be final. |
157
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
162
|
|
Missing a Javadoc comment. |
162
|
|
Parameter instanceOrClass should be final. |
162
|
|
Parameter method should be final. |
162
|
|
Parameter arg1 should be final. |
163
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
168
|
|
Missing a Javadoc comment. |
168
|
|
Parameter instanceOrClass should be final. |
168
|
|
Parameter method should be final. |
168
|
|
Parameter arg1 should be final. |
169
|
|
Parameter arg2 should be final. |
169
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
174
|
|
Missing a Javadoc comment. |
174
|
|
Parameter instanceOrClass should be final. |
174
|
|
Parameter method should be final. |
174
|
|
Parameter arg1 should be final. |
175
|
|
Parameter arg2 should be final. |
175
|
|
Parameter arg3 should be final. |
176
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
181
|
|
Missing a Javadoc comment. |
181
|
|
Parameter keys should be final. |
181
|
org/apache/torque/map/ColumnMap.java
| Error |
Line |
|
Name 'type' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
66
|
|
Name 'size' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
69
|
|
Name 'pk' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
72
|
|
Name 'notNull' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
75
|
|
Name 'relatedTableName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
78
|
|
Name 'relatedColumnName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
81
|
|
Name 'table' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
84
|
|
Name 'columnName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
87
|
|
Parameter name should be final. |
96
|
|
Parameter containingTable should be final. |
96
|
|
Method 'getColumnName' is not designed for extension - needs to be abstract, final or empty. |
107
|
|
Method 'getFullyQualifiedName' is not designed for extension - needs to be abstract, final or empty. |
117
|
|
Method 'getTableName' is not designed for extension - needs to be abstract, final or empty. |
127
|
|
Method 'setType' is not designed for extension - needs to be abstract, final or empty. |
137
|
|
Parameter type should be final. |
137
|
|
'type' hides a field. |
137
|
|
Method 'setSize' is not designed for extension - needs to be abstract, final or empty. |
147
|
|
Parameter size should be final. |
147
|
|
'size' hides a field. |
147
|
|
Method 'setPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
157
|
|
Parameter pk should be final. |
157
|
|
'pk' hides a field. |
157
|
|
Method 'setNotNull' is not designed for extension - needs to be abstract, final or empty. |
167
|
|
Parameter nn should be final. |
167
|
|
Method 'setForeignKey' is not designed for extension - needs to be abstract, final or empty. |
178
|
|
Parameter fullyQualifiedName should be final. |
178
|
|
Method 'setForeignKey' is not designed for extension - needs to be abstract, final or empty. |
200
|
|
Parameter tableName should be final. |
200
|
|
Parameter columnName should be final. |
200
|
|
'columnName' hides a field. |
200
|
|
Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
220
|
|
Method 'getSize' is not designed for extension - needs to be abstract, final or empty. |
230
|
|
Method 'isPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
240
|
|
Method 'isNotNull' is not designed for extension - needs to be abstract, final or empty. |
250
|
|
Method 'isForeignKey' is not designed for extension - needs to be abstract, final or empty. |
260
|
|
Method 'getRelatedName' is not designed for extension - needs to be abstract, final or empty. |
270
|
|
Method 'getRelatedTableName' is not designed for extension - needs to be abstract, final or empty. |
280
|
|
Method 'getRelatedColumnName' is not designed for extension - needs to be abstract, final or empty. |
290
|
org/apache/torque/map/DatabaseMap.java
| Error |
Line |
|
Name 'name' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
74
|
|
Name 'tables' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
77
|
|
Name 'idTable' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
83
|
|
Name 'idBroker' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
86
|
|
Name 'idGenerators' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
89
|
|
Parameter name should be final. |
104
|
|
'name' hides a field. |
104
|
|
Parameter numberOfTables should be final. |
104
|
|
'1.25' is a magic number. |
107
|
|
'6' is a magic number. |
108
|
|
Parameter name should be final. |
116
|
|
'name' hides a field. |
116
|
|
'6' is a magic number. |
120
|
|
Method 'containsTable' is not designed for extension - needs to be abstract, final or empty. |
129
|
|
Parameter table should be final. |
129
|
|
Method 'containsTable' is not designed for extension - needs to be abstract, final or empty. |
140
|
|
Parameter name should be final. |
140
|
|
'name' hides a field. |
140
|
|
Method 'getIdTable' is not designed for extension - needs to be abstract, final or empty. |
154
|
|
Method 'getIDBroker' is not designed for extension - needs to be abstract, final or empty. |
164
|
|
Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
174
|
|
Method 'getTable' is not designed for extension - needs to be abstract, final or empty. |
185
|
|
Parameter name should be final. |
185
|
|
'name' hides a field. |
185
|
|
Method 'getTables' is not designed for extension - needs to be abstract, final or empty. |
195
|
|
';' is preceded with whitespace. |
202
|
|
Method 'addTable' is not designed for extension - needs to be abstract, final or empty. |
213
|
|
Parameter tableName should be final. |
213
|
|
Method 'addTable' is not designed for extension - needs to be abstract, final or empty. |
226
|
|
Parameter tableName should be final. |
226
|
|
Parameter numberOfColumns should be final. |
226
|
|
Method 'addTable' is not designed for extension - needs to be abstract, final or empty. |
237
|
|
Parameter map should be final. |
237
|
|
Method 'setIdTable' is not designed for extension - needs to be abstract, final or empty. |
247
|
|
Parameter idTable should be final. |
247
|
|
'idTable' hides a field. |
247
|
|
Method 'setIdTable' is not designed for extension - needs to be abstract, final or empty. |
260
|
|
Parameter tableName should be final. |
260
|
|
Method 'addIdGenerator' is not designed for extension - needs to be abstract, final or empty. |
272
|
|
Parameter type should be final. |
272
|
|
Parameter idGen should be final. |
272
|
|
Method 'getIdGenerator' is not designed for extension - needs to be abstract, final or empty. |
284
|
|
Parameter type should be final. |
284
|
org/apache/torque/map/TableMap.java
| Error |
Line |
|
Name 'columns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
82
|
|
Name 'dbMap' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
85
|
|
Name 'tableName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
88
|
|
Name 'prefix' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
91
|
|
Name 'primaryKeyMethod' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
94
|
|
Name 'pkInfo' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
100
|
|
Parameter tableName should be final. |
116
|
|
'tableName' hides a field. |
116
|
|
Parameter numberOfColumns should be final. |
117
|
|
Parameter containingDB should be final. |
118
|
|
'1.25' is a magic number. |
122
|
|
Parameter tableName should be final. |
131
|
|
'tableName' hides a field. |
131
|
|
Parameter containingDB should be final. |
131
|
|
'20' is a magic number. |
135
|
|
Parameter tableName should be final. |
146
|
|
'tableName' hides a field. |
146
|
|
Parameter prefix should be final. |
147
|
|
'prefix' hides a field. |
147
|
|
Parameter containingDB should be final. |
148
|
|
'20' is a magic number. |
153
|
|
Method 'containsColumn' is not designed for extension - needs to be abstract, final or empty. |
162
|
|
Parameter column should be final. |
162
|
|
Method 'containsColumn' is not designed for extension - needs to be abstract, final or empty. |
173
|
|
Parameter name should be final. |
173
|
|
Method 'getDatabaseMap' is not designed for extension - needs to be abstract, final or empty. |
187
|
|
Method 'containsObjectColumn' is not designed for extension - needs to be abstract, final or empty. |
199
|
|
Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
219
|
|
Method 'getPrefix' is not designed for extension - needs to be abstract, final or empty. |
229
|
|
Method 'setPrefix' is not designed for extension - needs to be abstract, final or empty. |
240
|
|
Parameter prefix should be final. |
240
|
|
'prefix' hides a field. |
240
|
|
Method 'getPrimaryKeyMethod' is not designed for extension - needs to be abstract, final or empty. |
250
|
|
Method 'getIdGenerator' is not designed for extension - needs to be abstract, final or empty. |
259
|
|
Method 'getPrimaryKeyMethodInfo' is not designed for extension - needs to be abstract, final or empty. |
269
|
|
Method 'getColumns' is not designed for extension - needs to be abstract, final or empty. |
279
|
|
Method 'getColumn' is not designed for extension - needs to be abstract, final or empty. |
297
|
|
Parameter name should be final. |
297
|
|
Method 'addColumn' is not designed for extension - needs to be abstract, final or empty. |
315
|
|
Parameter cmap should be final. |
315
|
|
Method 'addColumn' is not designed for extension - needs to be abstract, final or empty. |
326
|
|
Parameter columnName should be final. |
326
|
|
Parameter type should be final. |
326
|
|
Method 'addColumn' is not designed for extension - needs to be abstract, final or empty. |
338
|
|
Parameter columnName should be final. |
338
|
|
Parameter type should be final. |
338
|
|
Parameter size should be final. |
338
|
|
Method 'addPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
349
|
|
Parameter columnName should be final. |
349
|
|
Parameter type should be final. |
349
|
|
Method 'addPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
361
|
|
Parameter columnName should be final. |
361
|
|
Parameter type should be final. |
361
|
|
Parameter size should be final. |
361
|
|
Method 'addForeignKey' is not designed for extension - needs to be abstract, final or empty. |
374
|
|
Parameter columnName should be final. |
374
|
|
Parameter type should be final. |
375
|
|
Parameter fkTable should be final. |
376
|
|
Parameter fkColumn should be final. |
377
|
|
Method 'addForeignKey' is not designed for extension - needs to be abstract, final or empty. |
391
|
|
Parameter columnName should be final. |
391
|
|
Parameter type should be final. |
392
|
|
Parameter fkTable should be final. |
393
|
|
Parameter fkColumn should be final. |
394
|
|
Parameter size should be final. |
395
|
|
Method 'addForeignPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
408
|
|
Parameter columnName should be final. |
408
|
|
Parameter type should be final. |
409
|
|
Parameter fkTable should be final. |
410
|
|
Parameter fkColumn should be final. |
411
|
|
Method 'addForeignPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
425
|
|
Parameter columnName should be final. |
425
|
|
Parameter type should be final. |
426
|
|
Parameter fkTable should be final. |
427
|
|
Parameter fkColumn should be final. |
428
|
|
Parameter size should be final. |
429
|
|
Parameter name should be final. |
444
|
|
Parameter type should be final. |
445
|
|
Parameter pk should be final. |
446
|
|
Parameter fkTable should be final. |
447
|
|
Parameter fkColumn should be final. |
448
|
|
Parameter size should be final. |
449
|
|
Method 'setPrimaryKeyMethod' is not designed for extension - needs to be abstract, final or empty. |
481
|
|
Parameter method should be final. |
481
|
|
Method 'setPrimaryKeyMethodInfo' is not designed for extension - needs to be abstract, final or empty. |
501
|
|
Parameter pkInfo should be final. |
501
|
|
'pkInfo' hides a field. |
501
|
|
Redundant 'final' modifier. |
514
|
|
Parameter data should be final. |
514
|
|
Redundant 'final' modifier. |
525
|
|
Parameter data should be final. |
525
|
|
Parameter data should be final. |
539
|
org/apache/torque/oid/AutoIncrementIdGenerator.java
| Error |
Line |
|
Name 'dbAdapter' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
75
|
|
Parameter adapter should be final. |
82
|
|
Method 'getIdAsInt' is not designed for extension - needs to be abstract, final or empty. |
95
|
|
Parameter connection should be final. |
95
|
|
Parameter keyInfo should be final. |
95
|
|
Method 'getIdAsLong' is not designed for extension - needs to be abstract, final or empty. |
109
|
|
Parameter connection should be final. |
109
|
|
Parameter keyInfo should be final. |
109
|
|
Method 'getIdAsBigDecimal' is not designed for extension - needs to be abstract, final or empty. |
124
|
|
Parameter connection should be final. |
124
|
|
Parameter keyInfo should be final. |
124
|
|
Method 'getIdAsString' is not designed for extension - needs to be abstract, final or empty. |
140
|
|
Parameter connection should be final. |
140
|
|
Parameter keyInfo should be final. |
140
|
|
Method 'isPriorToInsert' is not designed for extension - needs to be abstract, final or empty. |
151
|
|
Method 'isPostInsert' is not designed for extension - needs to be abstract, final or empty. |
161
|
|
Parameter connection should be final. |
186
|
|
Parameter keyInfo should be final. |
186
|
org/apache/torque/oid/IDBroker.java
| Error |
Line |
|
Name 'tableMap' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
139
|
|
Name 'ids' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
153
|
|
Name 'quantityStore' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
161
|
|
Name 'lastQueryTime' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
169
|
|
'60000' is a magic number. |
174
|
|
Name 'houseKeeperThread' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
184
|
|
Name 'transactionsSupported' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
189
|
|
Name 'configuration' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
197
|
|
Name 'log' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
212
|
|
Parameter tMap should be final. |
219
|
|
Must have at least one statement. |
258
|
|
Method 'setConfiguration' is not designed for extension - needs to be abstract, final or empty. |
278
|
|
Parameter configuration should be final. |
278
|
|
'configuration' hides a field. |
278
|
|
Method 'getIdAsInt' is not designed for extension - needs to be abstract, final or empty. |
295
|
|
Parameter connection should be final. |
295
|
|
Parameter tableName should be final. |
295
|
|
Method 'getIdAsLong' is not designed for extension - needs to be abstract, final or empty. |
314
|
|
Parameter connection should be final. |
314
|
|
Parameter tableName should be final. |
314
|
|
Method 'getIdAsBigDecimal' is not designed for extension - needs to be abstract, final or empty. |
332
|
|
Parameter connection should be final. |
332
|
|
Parameter tableName should be final. |
333
|
|
Method 'getIdAsString' is not designed for extension - needs to be abstract, final or empty. |
352
|
|
Parameter connection should be final. |
352
|
|
Parameter tableName should be final. |
352
|
|
Method 'isPriorToInsert' is not designed for extension - needs to be abstract, final or empty. |
363
|
|
Method 'isPostInsert' is not designed for extension - needs to be abstract, final or empty. |
373
|
|
Method 'isConnectionRequired' is not designed for extension - needs to be abstract, final or empty. |
384
|
|
Method 'getNextIds' is not designed for extension - needs to be abstract, final or empty. |
397
|
|
Parameter tableName should be final. |
397
|
|
Parameter numOfIdsToReturn should be final. |
398
|
|
Method 'getNextIds' is not designed for extension - needs to be abstract, final or empty. |
417
|
|
Parameter tableName should be final. |
417
|
|
Parameter numOfIdsToReturn should be final. |
418
|
|
Parameter connection should be final. |
419
|
|
Avoid inline conditionals. |
453
|
|
Method 'exists' is not designed for extension - needs to be abstract, final or empty. |
481
|
|
Parameter tableName should be final. |
481
|
|
Redundant throws: 'TorqueException' is subclass of 'Exception'. |
482
|
|
'100' is a magic number. |
484
|
|
Method 'run' is not designed for extension - needs to be abstract, final or empty. |
523
|
|
Must have at least one statement. |
535
|
|
Line is longer than 80 characters. |
561
|
|
Method 'stop' is not designed for extension - needs to be abstract, final or empty. |
582
|
|
Parameter tableName should be final. |
596
|
|
Parameter tableName should be final. |
643
|
|
Parameter adjustQuantity should be final. |
644
|
|
Parameter connection should be final. |
645
|
|
Parameter tableName should be final. |
734
|
|
Parameter connection should be final. |
734
|
|
'10' is a magic number. |
770
|
|
Parameter con should be final. |
797
|
|
Parameter tableName should be final. |
797
|
|
Parameter con should be final. |
849
|
|
Parameter tableName should be final. |
849
|
|
Parameter id should be final. |
849
|
|
'50' is a magic number. |
855
|
|
Parameter con should be final. |
893
|
|
Parameter tableName should be final. |
893
|
|
Parameter quantity should be final. |
894
|
|
'50' is a magic number. |
898
|
org/apache/torque/oid/IDGeneratorFactory.java
| Error |
Line |
|
Utility classes should not have a public or default constructor. |
67
|
|
Parameter dbAdapter should be final. |
88
|
org/apache/torque/oid/SequenceIdGenerator.java
| Error |
Line |
|
Name 'dbAdapter' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
82
|
|
Parameter adapter should be final. |
89
|
|
Method 'getIdAsInt' is not designed for extension - needs to be abstract, final or empty. |
102
|
|
Parameter connection should be final. |
102
|
|
Parameter keyInfo should be final. |
102
|
|
Method 'getIdAsLong' is not designed for extension - needs to be abstract, final or empty. |
116
|
|
Parameter connection should be final. |
116
|
|
Parameter keyInfo should be final. |
116
|
|
Method 'getIdAsBigDecimal' is not designed for extension - needs to be abstract, final or empty. |
130
|
|
Parameter connection should be final. |
130
|
|
Parameter keyInfo should be final. |
130
|
|
Method 'getIdAsString' is not designed for extension - needs to be abstract, final or empty. |
144
|
|
Parameter connection should be final. |
144
|
|
Parameter keyInfo should be final. |
144
|
|
Method 'isPriorToInsert' is not designed for extension - needs to be abstract, final or empty. |
155
|
|
Method 'isPostInsert' is not designed for extension - needs to be abstract, final or empty. |
165
|
|
Method 'isConnectionRequired' is not designed for extension - needs to be abstract, final or empty. |
176
|
|
Parameter connection should be final. |
189
|
|
Parameter keyInfo should be final. |
189
|
org/apache/torque/om/BaseObject.java
| Error |
Line |
|
Name 'isNew' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
86
|
|
Name 'primaryKey' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
89
|
|
Name 'modified' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
98
|
|
Name 'log' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
101
|
|
Method 'getPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
108
|
|
Method 'isModified' is not designed for extension - needs to be abstract, final or empty. |
118
|
|
Method 'isNew' is not designed for extension - needs to be abstract, final or empty. |
130
|
|
Method 'setNew' is not designed for extension - needs to be abstract, final or empty. |
141
|
|
Parameter b should be final. |
141
|
|
Method 'setPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
153
|
|
Parameter primaryKey should be final. |
153
|
|
'primaryKey' hides a field. |
153
|
|
Method 'setPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
165
|
|
Parameter primaryKey should be final. |
165
|
|
'primaryKey' hides a field. |
165
|
|
Method 'setPrimaryKey' is not designed for extension - needs to be abstract, final or empty. |
177
|
|
Parameter primaryKey should be final. |
177
|
|
'primaryKey' hides a field. |
177
|
|
Method 'setModified' is not designed for extension - needs to be abstract, final or empty. |
187
|
|
Parameter m should be final. |
187
|
|
Method 'resetModified' is not designed for extension - needs to be abstract, final or empty. |
195
|
|
Method 'getByName' is not designed for extension - needs to be abstract, final or empty. |
208
|
|
Parameter field should be final. |
208
|
|
Method 'getByPeerName' is not designed for extension - needs to be abstract, final or empty. |
221
|
|
Parameter name should be final. |
221
|
|
Method 'getByPosition' is not designed for extension - needs to be abstract, final or empty. |
234
|
|
Parameter pos should be final. |
234
|
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
247
|
|
Parameter obj should be final. |
247
|
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
265
|
|
Parameter bo should be final. |
265
|
|
Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
291
|
|
Method 'log' is not designed for extension - needs to be abstract, final or empty. |
308
|
|
Method 'getLog' is not designed for extension - needs to be abstract, final or empty. |
318
|
|
Parameter dbName should be final. |
335
|
|
Parameter con should be final. |
340
|
org/apache/torque/om/ComboKey.java
| Error |
Line |
|
Name 'key' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
81
|
|
Parameter keys should be final. |
97
|
|
Parameter keys should be final. |
108
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
118
|
|
Parameter keys should be final. |
118
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
129
|
|
Parameter keys should be final. |
129
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
185
|
|
Parameter keys should be final. |
185
|
|
Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
195
|
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
207
|
|
Parameter keyObj should be final. |
207
|
|
Method 'looseEquals' is not designed for extension - needs to be abstract, final or empty. |
245
|
|
Parameter keyObj should be final. |
245
|
|
Method 'appendTo' is not designed for extension - needs to be abstract, final or empty. |
293
|
|
Parameter sb should be final. |
293
|
|
Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
334
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
360
|
org/apache/torque/om/DateKey.java
| Error |
Line |
|
Parameter key should be final. |
84
|
|
Redundant throws: 'NumberFormatException' is unchecked exception. |
84
|
|
Parameter key should be final. |
94
|
|
Parameter key should be final. |
104
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
121
|
|
Parameter key should be final. |
121
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
131
|
|
Parameter key should be final. |
131
|
|
Method 'getDate' is not designed for extension - needs to be abstract, final or empty. |
148
|
|
Definition of 'equals()' without corresponding definition of 'hashCode()'. |
161
|
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
161
|
|
Parameter keyObj should be final. |
161
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
188
|
|
Avoid inline conditionals. |
191
|
org/apache/torque/om/NumberKey.java
| Error |
Line |
|
Parameter key should be final. |
84
|
|
Parameter key should be final. |
94
|
|
Parameter key should be final. |
104
|
|
Parameter key should be final. |
121
|
|
Parameter key should be final. |
131
|
|
Parameter key should be final. |
142
|
|
Parameter key should be final. |
153
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
172
|
|
Parameter key should be final. |
172
|
|
Redundant throws: 'NumberFormatException' is unchecked exception. |
172
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
182
|
|
Parameter key should be final. |
182
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
192
|
|
Parameter key should be final. |
192
|
|
Avoid inline conditionals. |
194
|
|
Method 'getBigDecimal' is not designed for extension - needs to be abstract, final or empty. |
202
|
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
214
|
|
Parameter keyObj should be final. |
214
|
|
Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
249
|
|
Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. |
265
|
|
Parameter o should be final. |
265
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
276
|
|
Method 'byteValue' is not designed for extension - needs to be abstract, final or empty. |
292
|
|
Method 'intValue' is not designed for extension - needs to be abstract, final or empty. |
309
|
|
Method 'shortValue' is not designed for extension - needs to be abstract, final or empty. |
326
|
|
Method 'longValue' is not designed for extension - needs to be abstract, final or empty. |
338
|
|
Method 'floatValue' is not designed for extension - needs to be abstract, final or empty. |
353
|
|
Method 'doubleValue' is not designed for extension - needs to be abstract, final or empty. |
368
|
org/apache/torque/om/ObjectKey.java
| Error |
Line |
|
Name 'key' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
74
|
|
Variable 'key' must be private and have accessor methods. |
74
|
|
Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
90
|
|
Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
104
|
|
Method 'appendTo' is not designed for extension - needs to be abstract, final or empty. |
114
|
|
Parameter sb should be final. |
114
|
|
Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. |
125
|
|
Parameter obj should be final. |
125
|
|
Parameter s should be final. |
136
|
org/apache/torque/om/SimpleKey.java
| Error |
Line |
|
Line has trailing spaces. |
59
|
|
Line has trailing spaces. |
71
|
|
Parameter key should be final. |
72
|
|
Line has trailing spaces. |
81
|
|
Parameter key should be final. |
82
|
|
Line has trailing spaces. |
91
|
|
Parameter key should be final. |
92
|
|
Line has trailing spaces. |
101
|
|
Parameter key should be final. |
102
|
|
Line has trailing spaces. |
111
|
|
Parameter key should be final. |
112
|
|
Line has trailing spaces. |
121
|
|
Parameter key should be final. |
122
|
|
Line has trailing spaces. |
131
|
|
Parameter key should be final. |
132
|
|
Line has trailing spaces. |
141
|
|
Parameter key should be final. |
142
|
|
Line has trailing spaces. |
151
|
|
Parameter key should be final. |
152
|
|
Line has trailing spaces. |
161
|
|
Parameter key should be final. |
162
|
org/apache/torque/om/StringKey.java
| Error |
Line |
|
Parameter key should be final. |
81
|
|
Parameter key should be final. |
91
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
108
|
|
Parameter key should be final. |
108
|
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. |
118
|
|
Parameter key should be final. |
118
|
|
Method 'getString' is not designed for extension - needs to be abstract, final or empty. |
135
|
|
Definition of 'equals()' without corresponding definition of 'hashCode()'. |
148
|
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
148
|
|
Parameter keyObj should be final. |
148
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
174
|
org/apache/torque/package.html
| Error |
Line |
|
Missing package documentation file. |
0 |
org/apache/torque/pool/ConnectionPool.java
| Error |
Line |
|
'60' is a magic number. |
93
|
|
'60' is a magic number. |
93
|
|
'1000' is a magic number. |
93
|
|
'10' is a magic number. |
96
|
|
'1000' is a magic number. |
96
|
|
Name 'pool' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
99
|
|
Name 'url' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
102
|
|
Name 'username' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
105
|
|
Name 'password' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
108
|
|
Name 'totalConnections' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
111
|
|
Name 'maxConnections' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
114
|
|
Name 'expiryTime' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
117
|
|
Name 'waitCount' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
123
|
|
Name 'logInterval' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
129
|
|
Name 'monitor' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
132
|
|
Name 'connectionWaitTimeout' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
138
|
|
Name 'cpds' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
141
|
|
Name 'timeStamps' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
147
|
|
Parameter cpds should be final. |
161
|
|
'cpds' hides a field. |
161
|
|
Parameter username should be final. |
161
|
|
'username' hides a field. |
161
|
|
Parameter password should be final. |
162
|
|
'password' hides a field. |
162
|
|
Parameter maxConnections should be final. |
162
|
|
'maxConnections' hides a field. |
162
|
|
Parameter expiryTime should be final. |
162
|
|
'expiryTime' hides a field. |
162
|
|
Parameter connectionWaitTimeout should be final. |
163
|
|
'connectionWaitTimeout' hides a field. |
163
|
|
Parameter logInterval should be final. |
163
|
|
'logInterval' hides a field. |
163
|
|
Avoid inline conditionals. |
174
|
|
Avoid inline conditionals. |
177
|
|
'1000' is a magic number. |
177
|
|
Avoid inline conditionals. |
181
|
|
'1000' is a magic number. |
181
|
|
'1000' is a magic number. |
184
|
|
Parameter username should be final. |
211
|
|
'username' hides a field. |
211
|
|
Parameter password should be final. |
212
|
|
'password' hides a field. |
212
|
|
'4' is a magic number. |
273
|
|
Avoid inline conditionals. |
276
|
|
Must have at least one statement. |
306
|
|
Comment matches to-do format 'TODO:'. |
364
|
|
Parameter pc should be final. |
375
|
|
Avoid inline conditionals. |
384
|
|
Parameter connection should be final. |
396
|
|
Must have at least one statement. |
451
|
|
Parameter event should be final. |
524
|
|
Parameter event should be final. |
535
|
|
Must have at least one statement. |
546
|
|
Must have at least one statement. |
555
|
|
Parameter pcon should be final. |
566
|
|
Parameter pcon should be final. |
583
|
|
Name 'isRun' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
617
|
|
Must have at least one statement. |
641
|
org/apache/torque/pool/ConnectionWaitTimeoutException.java
| Error |
Line |
|
Parameter url should be final. |
72
|
org/apache/torque/pool/TorqueClassicDataSource.java
| Error |
Line |
|
Name 'dataSourceName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
97
|
|
Name 'description' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
100
|
|
Name 'loginTimeout' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
103
|
|
Name 'cpds' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
106
|
|
Name 'logWriter' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
109
|
|
Name 'jndiEnvironment' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
112
|
|
Name 'defaultMaxConnections' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
115
|
|
Name 'perUserMaxConnections' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
121
|
|
Name 'maxExpiryTime' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
124
|
|
Name 'connectionWaitTimeout' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
130
|
|
Name 'logInterval' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
133
|
|
Name 'defaultAutoCommit' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
136
|
|
Name 'defaultReadOnly' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
139
|
|
Method 'getDefaultMaxConnections' is not designed for extension - needs to be abstract, final or empty. |
158
|
|
Method 'setDefaultMaxConnections' is not designed for extension - needs to be abstract, final or empty. |
170
|
|
Parameter v should be final. |
170
|
|
Method 'getPerUserMaxConnections' is not designed for extension - needs to be abstract, final or empty. |
182
|
|
Method 'setPerUserMaxConnections' is not designed for extension - needs to be abstract, final or empty. |
194
|
|
Parameter v should be final. |
194
|
|
Method 'getMaxExpiryTime' is not designed for extension - needs to be abstract, final or empty. |
205
|
|
Method 'setMaxExpiryTime' is not designed for extension - needs to be abstract, final or empty. |
216
|
|
Parameter v should be final. |
216
|
|
Method 'getConnectionWaitTimeout' is not designed for extension - needs to be abstract, final or empty. |
228
|
|
Method 'setConnectionWaitTimeout' is not designed for extension - needs to be abstract, final or empty. |
240
|
|
Parameter v should be final. |
240
|
|
Method 'getLogInterval' is not designed for extension - needs to be abstract, final or empty. |
252
|
|
Method 'setLogInterval' is not designed for extension - needs to be abstract, final or empty. |
264
|
|
Parameter v should be final. |
264
|
|
Method 'isDefaultAutoCommit' is not designed for extension - needs to be abstract, final or empty. |
277
|
|
Method 'setDefaultAutoCommit' is not designed for extension - needs to be abstract, final or empty. |
290
|
|
Parameter v should be final. |
290
|
|
Method 'isDefaultReadOnly' is not designed for extension - needs to be abstract, final or empty. |
303
|
|
Method 'setDefaultReadOnly' is not designed for extension - needs to be abstract, final or empty. |
316
|
|
Parameter v should be final. |
316
|
|
Method 'getDataSourceName' is not designed for extension - needs to be abstract, final or empty. |
328
|
|
Method 'setDataSourceName' is not designed for extension - needs to be abstract, final or empty. |
340
|
|
Parameter v should be final. |
340
|
|
Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. |
360
|
|
Method 'setDescription' is not designed for extension - needs to be abstract, final or empty. |
372
|
|
Parameter v should be final. |
372
|
|
Method 'getJndiEnvironment' is not designed for extension - needs to be abstract, final or empty. |
386
|
|
Parameter key should be final. |
386
|
|
Method 'setJndiEnvironment' is not designed for extension - needs to be abstract, final or empty. |
404
|
|
Parameter key should be final. |
404
|
|
Parameter value should be final. |
404
|
|
Method 'getConnectionPoolDataSource' is not designed for extension - needs to be abstract, final or empty. |
420
|
|
Method 'setConnectionPoolDataSource' is not designed for extension - needs to be abstract, final or empty. |
431
|
|
Parameter v should be final. |
431
|
|
Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
456
|
|
Expected @throws tag for 'SQLException'. |
456
|
|
Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
469
|
|
Parameter username should be final. |
469
|
|
Parameter password should be final. |
470
|
|
Expected @throws tag for 'SQLException'. |
471
|
|
Expected an @return tag. |
499
|
|
Parameter suffix should be final. |
499
|
|
Expected @param tag for 'suffix'. |
499
|
|
'private' modifier out of order with the JLS suggestions. |
521
|
|
Parameter username should be final. |
521
|
|
Parameter password should be final. |
521
|
|
Expected @throws tag for 'javax.naming.NamingException'. |
522
|
|
'cpds' hides a field. |
527
|
|
Method 'getLoginTimeout' is not designed for extension - needs to be abstract, final or empty. |
572
|
|
Method 'getLogWriter' is not designed for extension - needs to be abstract, final or empty. |
583
|
|
Method 'setLoginTimeout' is not designed for extension - needs to be abstract, final or empty. |
598
|
|
Parameter seconds should be final. |
598
|
|
Method 'setLogWriter' is not designed for extension - needs to be abstract, final or empty. |
609
|
|
Parameter out should be final. |
609
|
|
Method 'getReference' is not designed for extension - needs to be abstract, final or empty. |
620
|
|
Expected @throws tag for 'NamingException'. |
620
|
|
Method 'getObjectInstance' is not designed for extension - needs to be abstract, final or empty. |
666
|
|
Parameter refObj should be final. |
666
|
|
Expected @param tag for 'refObj'. |
666
|
|
Parameter name should be final. |
666
|
|
Expected @param tag for 'name'. |
666
|
|
Parameter context should be final. |
667
|
|
Expected @param tag for 'context'. |
667
|
|
Parameter env should be final. |
667
|
|
Expected @param tag for 'env'. |
667
|
|
Expected @throws tag for 'Exception'. |
668
|
org/apache/torque/util/BasePeer.java
| Error |
Line |
|
File length is 2,597 lines (max allowed is 2,000). |
1
|
|
Utility classes should not have a public or default constructor. |
115
|
|
Line has trailing spaces. |
129
|
|
Line has trailing spaces. |
131
|
|
Line has trailing spaces. |
132
|
|
'5' is a magic number. |
138
|
|
Variable 'log' must be private and have accessor methods. |
141
|
|
Parameter hash should be final. |
151
|
|
Must have at least one statement. |
198
|
|
Must have at least one statement. |
209
|
|
Must have at least one statement. |
220
|
|
Missing a Javadoc comment. |
227
|
|
Parameter e should be final. |
227
|
|
Line has trailing spaces. |
230
|
|
'cast' is not followed by whitespace. |
232
|
|
Line has trailing spaces. |
234
|
|
Parameter tableName should be final. |
247
|
|
Parameter tableName should be final. |
261
|
|
Parameter dbName should be final. |
261
|
|
Parameter schema should be final. |
292
|
|
Parameter columns should be final. |
319
|
|
Parameter tableName should be final. |
338
|
|
Parameter columnNames should be final. |
339
|
|
Parameter con should be final. |
362
|
|
Parameter table should be final. |
363
|
|
Parameter column should be final. |
364
|
|
Parameter value should be final. |
365
|
|
Must have at least one statement. |
396
|
|
Parameter table should be final. |
414
|
|
Parameter column should be final. |
414
|
|
Parameter value should be final. |
414
|
|
Parameter criteria should be final. |
438
|
|
Parameter criteria should be final. |
464
|
|
Parameter con should be final. |
464
|
|
Line is longer than 80 characters. |
565
|
|
Must have at least one statement. |
598
|
|
Parameter criteria should be final. |
629
|
|
Parameter criteria should be final. |
676
|
|
Parameter con should be final. |
676
|
|
Parameter rec should be final. |
798
|
|
Parameter tableName should be final. |
799
|
|
Parameter criteria should be final. |
800
|
|
Avoid inline conditionals. |
845
|
|
Parameter criteria should be final. |
920
|
|
Line has trailing spaces. |
938
|
|
Line has trailing spaces. |
940
|
|
Line has trailing spaces. |
943
|
|
Line has trailing spaces. |
944
|
|
Parameter query should be final. |
944
|
|
Parameter limit should be final. |
945
|
|
Expected @param tag for 'limit'. |
945
|
|
Parameter offset should be final. |
945
|
|
Expected @param tag for 'offset'. |
945
|
|
Parameter criteria should be final. |
981
|
|
Method length is 314 lines (max allowed is 150). |
1033
|
|
Parameter criteria should be final. |
1033
|
|
switch without "default" clause. |
1297
|
|
Parameter criteria should be final. |
1358
|
|
Parameter criteria should be final. |
1388
|
|
Parameter con should be final. |
1388
|
|
Parameter queryString should be final. |
1409
|
|
Parameter queryString should be final. |
1425
|
|
Parameter dbName should be final. |
1425
|
|
Parameter queryString should be final. |
1443
|
|
Parameter dbName should be final. |
1444
|
|
Parameter singleRecord should be final. |
1445
|
|
Parameter queryString should be final. |
1463
|
|
Parameter singleRecord should be final. |
1464
|
|
Parameter con should be final. |
1465
|
|
Parameter queryString should be final. |
1485
|
|
Parameter start should be final. |
1486
|
|
Parameter numberOfResults should be final. |
1487
|
|
Parameter dbName should be final. |
1488
|
|
Parameter singleRecord should be final. |
1489
|
|
Parameter queryString should be final. |
1526
|
|
Parameter start should be final. |
1527
|
|
Parameter numberOfResults should be final. |
1528
|
|
Parameter singleRecord should be final. |
1529
|
|
Parameter con should be final. |
1530
|
|
Line has trailing spaces. |
1542
|
|
Must have at least one statement. |
1561
|
|
Parameter qds should be final. |
1578
|
|
Parameter qds should be final. |
1595
|
|
Parameter singleRecord should be final. |
1595
|
|
Expected @param tag for 'singleRecord'. |
1595
|
|
Parameter qds should be final. |
1615
|
|
Parameter numberOfResults should be final. |
1616
|
|
Expected @param tag for 'numberOfResults'. |
1616
|
|
Parameter singleRecord should be final. |
1617
|
|
Expected @param tag for 'singleRecord'. |
1617
|
|
Parameter qds should be final. |
1645
|
|
Parameter start should be final. |
1646
|
|
Parameter numberOfResults should be final. |
1647
|
|
Parameter singleRecord should be final. |
1648
|
|
Parameter criteria should be final. |
1701
|
|
Parameter updateValues should be final. |
1754
|
|
Parameter updateValues should be final. |
1791
|
|
Parameter con should be final. |
1791
|
|
Parameter selectCriteria should be final. |
1827
|
|
Parameter updateValues should be final. |
1827
|
|
Parameter selectCriteria should be final. |
1863
|
|
Parameter updateValues should be final. |
1864
|
|
Parameter con should be final. |
1865
|
|
Line is longer than 80 characters. |
1925
|
|
Parameter stmt should be final. |
1974
|
|
Parameter stmt should be final. |
1990
|
|
Parameter dbName should be final. |
1990
|
|
Parameter stmt should be final. |
2018
|
|
Parameter con should be final. |
2018
|
|
Parameter ds should be final. |
2059
|
|
Parameter name should be final. |
2093
|
|
The double-checked locking idiom is broken and should be avoided. |
2105
|
|
Expected an @return tag. |
2159
|
|
Parameter criteria should be final. |
2159
|
|
Expected @param tag for 'criteria'. |
2159
|
|
Parameter con should be final. |
2159
|
|
Expected @param tag for 'con'. |
2159
|
|
Expected an @return tag. |
2235
|
|
Parameter criteria should be final. |
2235
|
|
Expected @param tag for 'criteria'. |
2235
|
|
Method length is 305 lines (max allowed is 150). |
2261
|
|
Parameter criteria should be final. |
2262
|
|
Expected @param tag for 'criteria'. |
2262
|
|
Parameter queryString should be final. |
2263
|
|
Expected @param tag for 'queryString'. |
2263
|
|
Parameter params should be final. |
2264
|
|
Expected @param tag for 'params'. |
2264
|
|
switch without "default" clause. |
2504
|
|
Parameter criteriaPhrase should be final. |
2587
|
|
Parameter columnName should be final. |
2588
|
org/apache/torque/util/Criteria.java
| Error |
Line |
|
File length is 3,595 lines (max allowed is 2,000). |
1
|
|
Missing a Javadoc comment. |
162
|
|
Missing a Javadoc comment. |
164
|
|
Name 'ignoreCase' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
164
|
|
Missing a Javadoc comment. |
165
|
|
Name 'singleRecord' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
165
|
|
Missing a Javadoc comment. |
166
|
|
Name 'cascade' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
166
|
|
Missing a Javadoc comment. |
167
|
|
Name 'selectModifiers' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
167
|
|
Missing a Javadoc comment. |
168
|
|
Name 'selectColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
168
|
|
Missing a Javadoc comment. |
169
|
|
Name 'orderByColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
169
|
|
Missing a Javadoc comment. |
170
|
|
Name 'groupByColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
170
|
|
Missing a Javadoc comment. |
171
|
|
Name 'having' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
171
|
|
Missing a Javadoc comment. |
172
|
|
Name 'asColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
172
|
|
'8' is a magic number. |
172
|
|
Missing a Javadoc comment. |
173
|
|
Name 'joinL' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
173
|
|
Missing a Javadoc comment. |
174
|
|
Name 'joinR' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
174
|
|
Name 'dbName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
177
|
|
Name 'originalDbName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
180
|
|
Name 'limit' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
186
|
|
Name 'offset' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
189
|
|
Missing a Javadoc comment. |
191
|
|
Name 'aliases' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
191
|
|
Missing a Javadoc comment. |
193
|
|
Name 'useTransaction' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
193
|
|
Parameter initialCapacity should be final. |
211
|
|
Parameter dbName should be final. |
222
|
|
'dbName' hides a field. |
222
|
|
Parameter dbName should be final. |
234
|
|
'dbName' hides a field. |
234
|
|
Parameter initialCapacity should be final. |
234
|
|
Method 'clear' is not designed for extension - needs to be abstract, final or empty. |
246
|
|
Method 'addAsColumn' is not designed for extension - needs to be abstract, final or empty. |
284
|
|
Parameter name should be final. |
284
|
|
Parameter clause should be final. |
284
|
|
Method 'getAsColumns' is not designed for extension - needs to be abstract, final or empty. |
296
|
|
Method 'addAlias' is not designed for extension - needs to be abstract, final or empty. |
308
|
|
Parameter alias should be final. |
308
|
|
Parameter table should be final. |
308
|
|
'8' is a magic number. |
312
|
|
Method 'getTableForAlias' is not designed for extension - needs to be abstract, final or empty. |
323
|
|
Parameter alias should be final. |
323
|
|
Method 'containsKey' is not designed for extension - needs to be abstract, final or empty. |
339
|
|
Parameter table should be final. |
339
|
|
Parameter column should be final. |
339
|
|
Method 'getBoolean' is not designed for extension - needs to be abstract, final or empty. |
350
|
|
Parameter column should be final. |
350
|
|
Method 'getBoolean' is not designed for extension - needs to be abstract, final or empty. |
362
|
|
Parameter table should be final. |
362
|
|
Parameter column should be final. |
362
|
|
Method 'setUseTransaction' is not designed for extension - needs to be abstract, final or empty. |
375
|
|
Parameter v should be final. |
375
|
|
Expected @param tag for 'v'. |
375
|
|
Method 'isUseTransaction' is not designed for extension - needs to be abstract, final or empty. |
386
|
|
Method 'getCriterion' is not designed for extension - needs to be abstract, final or empty. |
397
|
|
Parameter column should be final. |
397
|
|
Method 'getCriterion' is not designed for extension - needs to be abstract, final or empty. |
409
|
|
Parameter table should be final. |
409
|
|
Parameter column should be final. |
409
|
|
Method 'getNewCriterion' is not designed for extension - needs to be abstract, final or empty. |
425
|
|
Parameter column should be final. |
425
|
|
Parameter value should be final. |
425
|
|
Expected @param tag for 'value'. |
425
|
|
Parameter comparison should be final. |
426
|
|
Expected @param tag for 'comparison'. |
426
|
|
Method 'getNewCriterion' is not designed for extension - needs to be abstract, final or empty. |
440
|
|
Parameter table should be final. |
440
|
|
Parameter column should be final. |
440
|
|
Parameter value should be final. |
441
|
|
Expected @param tag for 'value'. |
441
|
|
Parameter comparison should be final. |
441
|
|
Expected @param tag for 'comparison'. |
441
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
464
|
|
Parameter c should be final. |
464
|
|
Method 'getColumnName' is not designed for extension - needs to be abstract, final or empty. |
481
|
|
Parameter name should be final. |
481
|
|
Method 'getComparison' is not designed for extension - needs to be abstract, final or empty. |
492
|
|
Parameter key should be final. |
492
|
|
Method 'getComparison' is not designed for extension - needs to be abstract, final or empty. |
504
|
|
Parameter table should be final. |
504
|
|
Parameter column should be final. |
504
|
|
Method 'getDate' is not designed for extension - needs to be abstract, final or empty. |
518
|
|
Parameter name should be final. |
518
|
|
Method 'getDate' is not designed for extension - needs to be abstract, final or empty. |
530
|
|
Parameter table should be final. |
530
|
|
Parameter column should be final. |
530
|
|
Method 'getDbName' is not designed for extension - needs to be abstract, final or empty. |
544
|
|
Method 'setDbName' is not designed for extension - needs to be abstract, final or empty. |
555
|
|
Parameter dbName should be final. |
555
|
|
'dbName' hides a field. |
555
|
|
Avoid inline conditionals. |
557
|
|
Method 'getDouble' is not designed for extension - needs to be abstract, final or empty. |
566
|
|
Parameter name should be final. |
566
|
|
Method 'getDouble' is not designed for extension - needs to be abstract, final or empty. |
583
|
|
Parameter table should be final. |
583
|
|
Parameter column should be final. |
583
|
|
Method 'getFloat' is not designed for extension - needs to be abstract, final or empty. |
596
|
|
Parameter name should be final. |
596
|
|
Method 'getFloat' is not designed for extension - needs to be abstract, final or empty. |
613
|
|
Parameter table should be final. |
613
|
|
Parameter column should be final. |
613
|
|
Method 'getInteger' is not designed for extension - needs to be abstract, final or empty. |
626
|
|
Parameter name should be final. |
626
|
|
Method 'getInteger' is not designed for extension - needs to be abstract, final or empty. |
643
|
|
Parameter table should be final. |
643
|
|
Parameter column should be final. |
643
|
|
Method 'getInt' is not designed for extension - needs to be abstract, final or empty. |
657
|
|
Parameter name should be final. |
657
|
|
Method 'getInt' is not designed for extension - needs to be abstract, final or empty. |
674
|
|
Parameter table should be final. |
674
|
|
Parameter column should be final. |
674
|
|
Method 'getBigDecimal' is not designed for extension - needs to be abstract, final or empty. |
688
|
|
Parameter name should be final. |
688
|
|
Method 'getBigDecimal' is not designed for extension - needs to be abstract, final or empty. |
705
|
|
Parameter table should be final. |
705
|
|
Parameter column should be final. |
705
|
|
Method 'getLong' is not designed for extension - needs to be abstract, final or empty. |
719
|
|
Parameter name should be final. |
719
|
|
Method 'getLong' is not designed for extension - needs to be abstract, final or empty. |
736
|
|
Parameter table should be final. |
736
|
|
Parameter column should be final. |
736
|
|
Method 'getString' is not designed for extension - needs to be abstract, final or empty. |
750
|
|
Parameter name should be final. |
750
|
|
Method 'getString' is not designed for extension - needs to be abstract, final or empty. |
762
|
|
Parameter table should be final. |
762
|
|
Parameter column should be final. |
762
|
|
Method 'getTableName' is not designed for extension - needs to be abstract, final or empty. |
776
|
|
Parameter name should be final. |
776
|
|
Method 'getList' is not designed for extension - needs to be abstract, final or empty. |
787
|
|
Parameter name should be final. |
787
|
|
Method 'getList' is not designed for extension - needs to be abstract, final or empty. |
799
|
|
Parameter table should be final. |
799
|
|
Parameter column should be final. |
799
|
|
Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
813
|
|
Parameter name should be final. |
813
|
|
Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
825
|
|
Parameter table should be final. |
825
|
|
Parameter column should be final. |
825
|
|
Method 'getObjectKey' is not designed for extension - needs to be abstract, final or empty. |
839
|
|
Parameter name should be final. |
839
|
|
Method 'getObjectKey' is not designed for extension - needs to be abstract, final or empty. |
851
|
|
Parameter table should be final. |
851
|
|
Parameter column should be final. |
851
|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. |
866
|
|
Parameter key should be final. |
866
|
|
Unused @throws tag for 'NullPointerException'. |
883
|
|
Method 'put' is not designed for extension - needs to be abstract, final or empty. |
886
|
|
Parameter key should be final. |
886
|
|
Parameter value should be final. |
886
|
|
Method 'putAll' is not designed for extension - needs to be abstract, final or empty. |
906
|
|
Parameter t should be final. |
906
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
969
|
|
Parameter column should be final. |
969
|
|
Parameter value should be final. |
969
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
999
|
|
Parameter column should be final. |
999
|
|
Parameter value should be final. |
999
|
|
Parameter comparison should be final. |
999
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1025
|
|
Parameter table should be final. |
1025
|
|
Parameter column should be final. |
1025
|
|
Parameter value should be final. |
1025
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1053
|
|
Parameter table should be final. |
1053
|
|
Parameter column should be final. |
1054
|
|
Parameter value should be final. |
1055
|
|
Parameter comparison should be final. |
1056
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1082
|
|
Parameter column should be final. |
1082
|
|
Parameter value should be final. |
1082
|
|
Avoid inline conditionals. |
1084
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1103
|
|
Parameter column should be final. |
1103
|
|
Parameter value should be final. |
1103
|
|
Parameter comparison should be final. |
1103
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1122
|
|
Parameter column should be final. |
1122
|
|
Parameter value should be final. |
1122
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1143
|
|
Parameter column should be final. |
1143
|
|
Parameter value should be final. |
1143
|
|
Parameter comparison should be final. |
1143
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1162
|
|
Parameter column should be final. |
1162
|
|
Parameter value should be final. |
1162
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1183
|
|
Parameter column should be final. |
1183
|
|
Parameter value should be final. |
1183
|
|
Parameter comparison should be final. |
1183
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1202
|
|
Parameter column should be final. |
1202
|
|
Parameter value should be final. |
1202
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1223
|
|
Parameter column should be final. |
1223
|
|
Parameter value should be final. |
1223
|
|
Parameter comparison should be final. |
1223
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1242
|
|
Parameter column should be final. |
1242
|
|
Parameter value should be final. |
1242
|
|
Method 'add' is not designed for extension - needs to be abstract, final or empty. |
1263
|
|
Parameter column should be final. |
1263
|
|
Parameter value should be final. |
1263
|
|
Parameter comparison should be final. |
1263
|
|
Method 'addDate' is not designed for extension - needs to be abstract, final or empty. |
1286
|
|
Parameter column should be final. |
1286
|
|
Parameter year should be final. |
1286
|
|
Parameter month should be final. |
1286
|
|
Parameter date should be final. |
1286
|
|
Method 'addDate' is not designed for extension - needs to be abstract, final or empty. |
1311
|
|
Parameter column should be final. |
1311
|
|
Parameter year should be final. |
1311
|
|
Parameter month should be final. |
1311
|
|
Parameter date should be final. |
1311
|
|
Parameter comparison should be final. |
1312
|
|
Method 'addJoin' is not designed for extension - needs to be abstract, final or empty. |
1334
|
|
Parameter left should be final. |
1334
|
|
Parameter right should be final. |
1334
|
|
'3' is a magic number. |
1338
|
|
'3' is a magic number. |
1339
|
|
Expected an @return tag. |
1351
|
|
Method 'getJoinL' is not designed for extension - needs to be abstract, final or empty. |
1351
|
|
Expected an @return tag. |
1360
|
|
Method 'getJoinR' is not designed for extension - needs to be abstract, final or empty. |
1360
|
|
Method 'addIn' is not designed for extension - needs to be abstract, final or empty. |
1383
|
|
Parameter column should be final. |
1383
|
|
Parameter values should be final. |
1383
|
|
Method 'addIn' is not designed for extension - needs to be abstract, final or empty. |
1406
|
|
Parameter column should be final. |
1406
|
|
Parameter values should be final. |
1406
|
|
Method 'addIn' is not designed for extension - needs to be abstract, final or empty. |
1430
|
|
Parameter column should be final. |
1430
|
|
Parameter values should be final. |
1430
|
|
Method 'addNotIn' is not designed for extension - needs to be abstract, final or empty. |
1454
|
|
Parameter column should be final. |
1454
|
|
Parameter values should be final. |
1454
|
|
Method 'addNotIn' is not designed for extension - needs to be abstract, final or empty. |
1477
|
|
Parameter column should be final. |
1477
|
|
Parameter values should be final. |
1477
|
|
Method 'addNotIn' is not designed for extension - needs to be abstract, final or empty. |
1501
|
|
Parameter column should be final. |
1501
|
|
Parameter values should be final. |
1501
|
|
Method 'setAll' is not designed for extension - needs to be abstract, final or empty. |
1510
|
|
Method 'setDistinct' is not designed for extension - needs to be abstract, final or empty. |
1518
|
|
Method 'setIgnoreCase' is not designed for extension - needs to be abstract, final or empty. |
1529
|
|
Parameter b should be final. |
1529
|
|
Method 'isIgnoreCase' is not designed for extension - needs to be abstract, final or empty. |
1540
|
|
Method 'setSingleRecord' is not designed for extension - needs to be abstract, final or empty. |
1558
|
|
Parameter b should be final. |
1558
|
|
Method 'isSingleRecord' is not designed for extension - needs to be abstract, final or empty. |
1569
|
|
Method 'setCascade' is not designed for extension - needs to be abstract, final or empty. |
1580
|
|
Parameter b should be final. |
1580
|
|
Method 'isCascade' is not designed for extension - needs to be abstract, final or empty. |
1591
|
|
Method 'setLimit' is not designed for extension - needs to be abstract, final or empty. |
1602
|
|
Parameter limit should be final. |
1602
|
|
'limit' hides a field. |
1602
|
|
Method 'getLimit' is not designed for extension - needs to be abstract, final or empty. |
1613
|
|
Method 'setOffset' is not designed for extension - needs to be abstract, final or empty. |
1624
|
|
Parameter offset should be final. |
1624
|
|
'offset' hides a field. |
1624
|
|
Method 'getOffset' is not designed for extension - needs to be abstract, final or empty. |
1635
|
|
Method 'addSelectColumn' is not designed for extension - needs to be abstract, final or empty. |
1646
|
|
Parameter name should be final. |
1646
|
|
Method 'getSelectColumns' is not designed for extension - needs to be abstract, final or empty. |
1658
|
|
Method 'getSelectModifiers' is not designed for extension - needs to be abstract, final or empty. |
1668
|
|
Method 'addGroupByColumn' is not designed for extension - needs to be abstract, final or empty. |
1679
|
|
Parameter groupBy should be final. |
1679
|
|
Method 'addAscendingOrderByColumn' is not designed for extension - needs to be abstract, final or empty. |
1691
|
|
Parameter name should be final. |
1691
|
|
Method 'addDescendingOrderByColumn' is not designed for extension - needs to be abstract, final or empty. |
1703
|
|
Parameter name should be final. |
1703
|
|
Method 'getOrderByColumns' is not designed for extension - needs to be abstract, final or empty. |
1714
|
|
Method 'getGroupByColumns' is not designed for extension - needs to be abstract, final or empty. |
1724
|
|
Method 'getHaving' is not designed for extension - needs to be abstract, final or empty. |
1734
|
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
1745
|
|
Parameter key should be final. |
1745
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
1760
|
|
Line is longer than 80 characters. |
1773
|
|
Must have at least one statement. |
1777
|
|
Expected an @return tag. |
1787
|
|
Definition of 'equals()' without corresponding definition of 'hashCode()'. |
1787
|
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
1787
|
|
Parameter crit should be final. |
1787
|
|
Expected @param tag for 'crit'. |
1787
|
|
Method 'addHaving' is not designed for extension - needs to be abstract, final or empty. |
1861
|
|
Parameter having should be final. |
1861
|
|
'having' hides a field. |
1861
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
1885
|
|
Parameter c should be final. |
1885
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
1922
|
|
Parameter column should be final. |
1922
|
|
Parameter value should be final. |
1922
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
1952
|
|
Parameter column should be final. |
1952
|
|
Parameter value should be final. |
1952
|
|
Parameter comparison should be final. |
1952
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
1987
|
|
Parameter table should be final. |
1987
|
|
Parameter column should be final. |
1987
|
|
Parameter value should be final. |
1987
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2015
|
|
Parameter table should be final. |
2015
|
|
Parameter column should be final. |
2015
|
|
Parameter value should be final. |
2015
|
|
Parameter comparison should be final. |
2016
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2051
|
|
Parameter column should be final. |
2051
|
|
Parameter value should be final. |
2051
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2072
|
|
Parameter column should be final. |
2072
|
|
Parameter value should be final. |
2072
|
|
Parameter comparison should be final. |
2072
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2091
|
|
Parameter column should be final. |
2091
|
|
Parameter value should be final. |
2091
|
|
Line is longer than 80 characters. |
2108
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2111
|
|
Parameter column should be final. |
2111
|
|
Parameter value should be final. |
2111
|
|
Parameter comparison should be final. |
2111
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2130
|
|
Parameter column should be final. |
2130
|
|
Parameter value should be final. |
2130
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2151
|
|
Parameter column should be final. |
2151
|
|
Parameter value should be final. |
2151
|
|
Parameter comparison should be final. |
2151
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2170
|
|
Parameter column should be final. |
2170
|
|
Parameter value should be final. |
2170
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2191
|
|
Parameter column should be final. |
2191
|
|
Parameter value should be final. |
2191
|
|
Parameter comparison should be final. |
2191
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2210
|
|
Parameter column should be final. |
2210
|
|
Parameter value should be final. |
2210
|
|
Method 'and' is not designed for extension - needs to be abstract, final or empty. |
2231
|
|
Parameter column should be final. |
2231
|
|
Parameter value should be final. |
2231
|
|
Parameter comparison should be final. |
2231
|
|
Method 'andDate' is not designed for extension - needs to be abstract, final or empty. |
2253
|
|
Parameter column should be final. |
2253
|
|
Parameter year should be final. |
2253
|
|
Parameter month should be final. |
2253
|
|
Parameter date should be final. |
2253
|
|
Method 'andDate' is not designed for extension - needs to be abstract, final or empty. |
2277
|
|
Parameter column should be final. |
2277
|
|
Parameter year should be final. |
2277
|
|
Parameter month should be final. |
2277
|
|
Parameter date should be final. |
2277
|
|
Parameter comparison should be final. |
2278
|
|
Method 'andIn' is not designed for extension - needs to be abstract, final or empty. |
2302
|
|
Parameter column should be final. |
2302
|
|
Parameter values should be final. |
2302
|
|
Method 'andIn' is not designed for extension - needs to be abstract, final or empty. |
2325
|
|
Parameter column should be final. |
2325
|
|
Parameter values should be final. |
2325
|
|
Method 'andIn' is not designed for extension - needs to be abstract, final or empty. |
2349
|
|
Parameter column should be final. |
2349
|
|
Parameter values should be final. |
2349
|
|
Method 'andNotIn' is not designed for extension - needs to be abstract, final or empty. |
2373
|
|
Parameter column should be final. |
2373
|
|
Parameter values should be final. |
2373
|
|
Method 'andNotIn' is not designed for extension - needs to be abstract, final or empty. |
2396
|
|
Parameter column should be final. |
2396
|
|
Parameter values should be final. |
2396
|
|
Method 'andNotIn' is not designed for extension - needs to be abstract, final or empty. |
2420
|
|
Parameter column should be final. |
2420
|
|
Parameter values should be final. |
2420
|
|
Line is longer than 80 characters. |
2444
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2451
|
|
Parameter c should be final. |
2451
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2488
|
|
Parameter column should be final. |
2488
|
|
Parameter value should be final. |
2488
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2517
|
|
Parameter column should be final. |
2517
|
|
Parameter value should be final. |
2517
|
|
Parameter comparison should be final. |
2517
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2552
|
|
Parameter table should be final. |
2552
|
|
Parameter column should be final. |
2552
|
|
Parameter value should be final. |
2552
|
|
Line is longer than 80 characters. |
2576
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2579
|
|
Parameter table should be final. |
2579
|
|
Parameter column should be final. |
2579
|
|
Parameter value should be final. |
2579
|
|
Parameter comparison should be final. |
2580
|
|
Line is longer than 80 characters. |
2582
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2613
|
|
Parameter column should be final. |
2613
|
|
Parameter value should be final. |
2613
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2634
|
|
Parameter column should be final. |
2634
|
|
Parameter value should be final. |
2634
|
|
Parameter comparison should be final. |
2634
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2654
|
|
Parameter column should be final. |
2654
|
|
Parameter value should be final. |
2654
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2676
|
|
Parameter column should be final. |
2676
|
|
Parameter value should be final. |
2676
|
|
Parameter comparison should be final. |
2676
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2695
|
|
Parameter column should be final. |
2695
|
|
Parameter value should be final. |
2695
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2716
|
|
Parameter column should be final. |
2716
|
|
Parameter value should be final. |
2716
|
|
Parameter comparison should be final. |
2716
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2735
|
|
Parameter column should be final. |
2735
|
|
Parameter value should be final. |
2735
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2756
|
|
Parameter column should be final. |
2756
|
|
Parameter value should be final. |
2756
|
|
Parameter comparison should be final. |
2756
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2775
|
|
Parameter column should be final. |
2775
|
|
Parameter value should be final. |
2775
|
|
Method 'or' is not designed for extension - needs to be abstract, final or empty. |
2796
|
|
Parameter column should be final. |
2796
|
|
Parameter value should be final. |
2796
|
|
Parameter comparison should be final. |
2796
|
|
Method 'orDate' is not designed for extension - needs to be abstract, final or empty. |
2818
|
|
Parameter column should be final. |
2818
|
|
Parameter year should be final. |
2818
|
|
Parameter month should be final. |
2818
|
|
Parameter date should be final. |
2818
|
|
Method 'orDate' is not designed for extension - needs to be abstract, final or empty. |
2842
|
|
Parameter column should be final. |
2842
|
|
Parameter year should be final. |
2842
|
|
Parameter month should be final. |
2842
|
|
Parameter date should be final. |
2842
|
|
Parameter comparison should be final. |
2843
|
|
Method 'orIn' is not designed for extension - needs to be abstract, final or empty. |
2867
|
|
Parameter column should be final. |
2867
|
|
Parameter values should be final. |
2867
|
|
Method 'orIn' is not designed for extension - needs to be abstract, final or empty. |
2890
|
|
Parameter column should be final. |
2890
|
|
Parameter values should be final. |
2890
|
|
Method 'orIn' is not designed for extension - needs to be abstract, final or empty. |
2914
|
|
Parameter column should be final. |
2914
|
|
Parameter values should be final. |
2914
|
|
Method 'orNotIn' is not designed for extension - needs to be abstract, final or empty. |
2938
|
|
Parameter column should be final. |
2938
|
|
Parameter values should be final. |
2938
|
|
Method 'orNotIn' is not designed for extension - needs to be abstract, final or empty. |
2961
|
|
Parameter column should be final. |
2961
|
|
Parameter values should be final. |
2961
|
|
Method 'orNotIn' is not designed for extension - needs to be abstract, final or empty. |
2985
|
|
Parameter column should be final. |
2985
|
|
Parameter values should be final. |
2985
|
|
Line has trailing spaces. |
2996
|
|
Parameter b should be final. |
2999
|
|
Expected @param tag for 'b'. |
2999
|
|
Line has trailing spaces. |
3001
|
|
Missing a Javadoc comment. |
3010
|
|
Missing a Javadoc comment. |
3011
|
|
Name 'value' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3014
|
|
Name 'comparison' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3017
|
|
Name 'table' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3020
|
|
Name 'column' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3023
|
|
Name 'ignoreStringCase' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3026
|
|
Name 'db' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3032
|
|
Name 'clauses' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3037
|
|
Missing a Javadoc comment. |
3038
|
|
Name 'conjunctions' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
3038
|
|
Parameter val should be final. |
3043
|
|
Expected @param tag for 'val'. |
3043
|
|
Parameter comp should be final. |
3043
|
|
Expected @param tag for 'comp'. |
3043
|
|
Parameter table should be final. |
3057
|
|
'table' hides a field. |
3057
|
|
Parameter column should be final. |
3057
|
|
'column' hides a field. |
3057
|
|
Parameter val should be final. |
3057
|
|
Parameter comp should be final. |
3057
|
|
Avoid inline conditionals. |
3060
|
|
Avoid inline conditionals. |
3061
|
|
Parameter tableColumn should be final. |
3072
|
|
Parameter val should be final. |
3072
|
|
Parameter comp should be final. |
3072
|
|
Parameter table should be final. |
3095
|
|
'table' hides a field. |
3095
|
|
Parameter column should be final. |
3095
|
|
'column' hides a field. |
3095
|
|
Parameter val should be final. |
3095
|
|
Parameter tableColumn should be final. |
3107
|
|
Parameter val should be final. |
3107
|
|
Parameter name should be final. |
3127
|
|
'db' hides a field. |
3170
|
|
Parameter v should be final. |
3201
|
|
Parameter b should be final. |
3217
|
|
Expected an @return tag. |
3236
|
|
Expected an @return tag. |
3244
|
|
Expected an @return tag. |
3252
|
|
Parameter criterion should be final. |
3252
|
|
Expected @param tag for 'criterion'. |
3252
|
|
Expected an @return tag. |
3262
|
|
Parameter criterion should be final. |
3262
|
|
Expected @param tag for 'criterion'. |
3262
|
|
Parameter sb should be final. |
3272
|
|
Expected @param tag for 'sb'. |
3272
|
|
Parameter sb should be final. |
3330
|
|
Parameter params should be final. |
3330
|
|
'db' hides a field. |
3337
|
|
'25' is a magic number. |
3448
|
|
Expected an @return tag. |
3457
|
|
Parameter obj should be final. |
3457
|
|
Expected @param tag for 'obj'. |
3457
|
|
Expected an @return tag. |
3512
|
|
Parameter c should be final. |
3550
|
|
Expected @param tag for 'c'. |
3550
|
|
Parameter s should be final. |
3550
|
|
Expected @param tag for 's'. |
3550
|
|
Expected an @return tag. |
3566
|
|
Parameter c should be final. |
3583
|
|
Expected @param tag for 'c'. |
3583
|
|
Parameter a should be final. |
3583
|
|
Expected @param tag for 'a'. |
3583
|
org/apache/torque/util/LargeSelect.java
| Error |
Line |
|
Name 'pageSize' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
177
|
|
Name 'memoryLimit' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
179
|
|
Name 'blockBegin' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
182
|
|
Name 'blockEnd' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
184
|
|
Name 'currentlyFilledTo' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
186
|
|
Name 'query' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
189
|
|
Name 'dbName' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
191
|
|
Name 'qds' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
193
|
|
Name 'results' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
196
|
|
Name 'thread' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
199
|
|
Name 'killThread' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
204
|
|
Name 'threadRunning' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
206
|
|
Name 'queryCompleted' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
211
|
|
Name 'totalsFinalized' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
216
|
|
Name 'position' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
219
|
|
Name 'totalPages' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
221
|
|
Name 'totalRecords' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
223
|
|
Name 'currentPageNumber' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
225
|
|
Name 'criteria' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
228
|
|
Name 'lastResults' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
230
|
|
Name 'returnBuilderClass' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
236
|
|
Name 'populateObjectsMethod' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
241
|
|
Missing a Javadoc comment. |
250
|
|
Missing a Javadoc comment. |
259
|
|
Name 'params' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
262
|
|
Parameter criteria should be final. |
281
|
|
'criteria' hides a field. |
281
|
|
Parameter pageSize should be final. |
281
|
|
'pageSize' hides a field. |
281
|
|
Redundant throws: 'IllegalArgumentException' is unchecked exception. |
282
|
|
Parameter criteria should be final. |
304
|
|
'criteria' hides a field. |
304
|
|
Parameter pageSize should be final. |
304
|
|
'pageSize' hides a field. |
304
|
|
Parameter memoryPageLimit should be final. |
304
|
|
'memoryPageLimit' hides a field. |
304
|
|
Redundant throws: 'IllegalArgumentException' is unchecked exception. |
305
|
|
Parameter criteria should be final. |
335
|
|
'criteria' hides a field. |
335
|
|
Parameter pageSize should be final. |
336
|
|
'pageSize' hides a field. |
336
|
|
Parameter returnBuilderClassName should be final. |
337
|
|
Redundant throws: 'IllegalArgumentException' is unchecked exception. |
338
|
|
Parameter criteria should be final. |
375
|
|
'criteria' hides a field. |
375
|
|
Parameter pageSize should be final. |
376
|
|
'pageSize' hides a field. |
376
|
|
Parameter memoryPageLimit should be final. |
377
|
|
'memoryPageLimit' hides a field. |
377
|
|
Parameter returnBuilderClassName should be final. |
378
|
|
Redundant throws: 'IllegalArgumentException' is unchecked exception. |
379
|
|
'{' is followed by whitespace. |
388
|
|
'{' is followed by whitespace. |
391
|
|
'{' is followed by whitespace. |
397
|
|
Parameter criteria should be final. |
425
|
|
'criteria' hides a field. |
425
|
|
Parameter pageSize should be final. |
425
|
|
'pageSize' hides a field. |
425
|
|
Parameter memoryLimitPages should be final. |
425
|
|
Redundant throws: 'IllegalArgumentException' is unchecked exception. |
426
|
|
Unused @throws tag for 'IllegalArgumentException'. |
462
|
|
Method 'getPage' is not designed for extension - needs to be abstract, final or empty. |
467
|
|
Parameter pageNumber should be final. |
467
|
|
Method 'getNextResults' is not designed for extension - needs to be abstract, final or empty. |
486
|
|
Method 'getCurrentPageResults' is not designed for extension - needs to be abstract, final or empty. |
502
|
|
Method 'getPreviousResults' is not designed for extension - needs to be abstract, final or empty. |
515
|
|
Parameter start should be final. |
545
|
|
Parameter start should be final. |
564
|
|
Parameter size should be final. |
564
|
|
Redundant throws: 'IllegalArgumentException' is unchecked exception. |
565
|
|
'500' is a magic number. |
595
|
|
'{' is followed by whitespace. |
670
|
|
Method 'run' is not designed for extension - needs to be abstract, final or empty. |
691
|
|
Parameter initialSize should be final. |
837
|
|
'100' is a magic number. |
865
|
|
Method 'getCurrentPageNumber' is not designed for extension - needs to be abstract, final or empty. |
881
|
|
Method 'getTotalRecords' is not designed for extension - needs to be abstract, final or empty. |
896
|
|
Method 'getPaginated' is not designed for extension - needs to be abstract, final or empty. |
907
|
|
Method 'getTotalPages' is not designed for extension - needs to be abstract, final or empty. |
927
|
|
Avoid inline conditionals. |
936
|
|
Method 'getPageSize' is not designed for extension - needs to be abstract, final or empty. |
952
|
|
Method 'getTotalsFinalized' is not designed for extension - needs to be abstract, final or empty. |
964
|
|
Parameter moreIndicator should be final. |
975
|
|
'moreIndicator' hides a field. |
975
|
|
Expected an @return tag. |
983
|
|
Parameter memoryPageLimit should be final. |
996
|
|
'memoryPageLimit' hides a field. |
996
|
|
Expected an @return tag. |
1006
|
|
Method 'getPageProgressText' is not designed for extension - needs to be abstract, final or empty. |
1018
|
|
Method 'getCurrentPageSize' is not designed for extension - needs to be abstract, final or empty. |
1039
|
|
Method 'getFirstRecordNoForPage' is not designed for extension - needs to be abstract, final or empty. |
1053
|
|
Method 'getLastRecordNoForPage' is not designed for extension - needs to be abstract, final or empty. |
1067
|
|
Method 'getRecordProgressText' is not designed for extension - needs to be abstract, final or empty. |
1084
|
|
Method 'getNextResultsAvailable' is not designed for extension - needs to be abstract, final or empty. |
1105
|
|
Method 'getPreviousResultsAvailable' is not designed for extension - needs to be abstract, final or empty. |
1119
|
|
Method 'hasResultsAvailable' is not designed for extension - needs to be abstract, final or empty. |
1133
|
|
Method 'invalidateResult' is not designed for extension - needs to be abstract, final or empty. |
1145
|
|
Line has trailing spaces. |
1157
|
|
Method 'getSearchParam' is not designed for extension - needs to be abstract, final or empty. |
1175
|
|
Parameter name should be final. |
1175
|
|
Method 'getSearchParam' is not designed for extension - needs to be abstract, final or empty. |
1191
|
|
Parameter name should be final. |
1191
|
|
Parameter defaultValue should be final. |
1191
|
|
Avoid inline conditionals. |
1198
|
|
Line has trailing spaces. |
1202
|
|
Method 'setSearchParam' is not designed for extension - needs to be abstract, final or empty. |
1208
|
|
Parameter name should be final. |
1208
|
|
Parameter value should be final. |
1208
|
|
Method 'removeSearchParam' is not designed for extension - needs to be abstract, final or empty. |
1232
|
|
Parameter name should be final. |
1232
|
|
Line has trailing spaces. |
1242
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
1245
|
org/apache/torque/util/Query.java
| Error |
Line |
|
Missing a Javadoc comment. |
73
|
|
Missing a Javadoc comment. |
74
|
|
Missing a Javadoc comment. |
75
|
|
Missing a Javadoc comment. |
76
|
|
Missing a Javadoc comment. |
77
|
|
Missing a Javadoc comment. |
78
|
|
Missing a Javadoc comment. |
79
|
|
Missing a Javadoc comment. |
80
|
|
Missing a Javadoc comment. |
81
|
|
Missing a Javadoc comment. |
83
|
|
Name 'selectModifiers' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
83
|
|
Missing a Javadoc comment. |
84
|
|
Name 'selectColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
84
|
|
Missing a Javadoc comment. |
85
|
|
Name 'fromTables' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
85
|
|
Missing a Javadoc comment. |
86
|
|
Name 'whereCriteria' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
86
|
|
Missing a Javadoc comment. |
87
|
|
Name 'orderByColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
87
|
|
Missing a Javadoc comment. |
88
|
|
Name 'groupByColumns' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
88
|
|
Missing a Javadoc comment. |
89
|
|
Name 'having' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
89
|
|
Missing a Javadoc comment. |
90
|
|
Name 'limit' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
90
|
|
Missing a Javadoc comment. |
91
|
|
Name 'rowcount' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
91
|
|
Method 'getSelectModifiers' is not designed for extension - needs to be abstract, final or empty. |
99
|
|
Method 'setSelectModifiers' is not designed for extension - needs to be abstract, final or empty. |
109
|
|
Parameter modifiers should be final. |
109
|
|
Method 'getSelectClause' is not designed for extension - needs to be abstract, final or empty. |
121
|
|
Method 'setSelectClause' is not designed for extension - needs to be abstract, final or empty. |
131
|
|
Parameter columns should be final. |
131
|
|
Method 'getFromClause' is not designed for extension - needs to be abstract, final or empty. |
142
|
|
Method 'setFromClause' is not designed for extension - needs to be abstract, final or empty. |
152
|
|
Parameter tables should be final. |
152
|
|
Method 'getWhereClause' is not designed for extension - needs to be abstract, final or empty. |
164
|
|
Method 'setWhereClause' is not designed for extension - needs to be abstract, final or empty. |
174
|
|
Parameter where should be final. |
174
|
|
Method 'getOrderByClause' is not designed for extension - needs to be abstract, final or empty. |
185
|
|
Method 'getGroupByClause' is not designed for extension - needs to be abstract, final or empty. |
196
|
|
Method 'setHaving' is not designed for extension - needs to be abstract, final or empty. |
207
|
|
Parameter having should be final. |
207
|
|
'having' hides a field. |
207
|
|
Method 'setLimit' is not designed for extension - needs to be abstract, final or empty. |
218
|
|
Parameter limit should be final. |
218
|
|
'limit' hides a field. |
218
|
|
Method 'setRowcount' is not designed for extension - needs to be abstract, final or empty. |
229
|
|
Parameter rowcount should be final. |
229
|
|
'rowcount' hides a field. |
229
|
|
Method 'getHaving' is not designed for extension - needs to be abstract, final or empty. |
240
|
|
Method 'getLimit' is not designed for extension - needs to be abstract, final or empty. |
251
|
|
Method 'getRowcount' is not designed for extension - needs to be abstract, final or empty. |
262
|
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
272
|
org/apache/torque/util/SqlEnum.java
| Error |
Line |
|
Class SqlEnum should be declared as final. |
67
|
|
Missing a Javadoc comment. |
69
|
|
Name 's' must match pattern '^f[A-Z][a-zA-Z0-9]*$'. |
69
|
|
Line has trailing spaces. |
70
|
|
Line has trailing spaces. |
71
|
|
Missing a Javadoc comment. |
71
|
|
Parameter s should be final. |
71
|
|
's' hides a field. |
71
|
|
Line has trailing spaces. |
72
|
|
Line has trailing spaces. |
76
|
|
Missing a Javadoc comment. |
76
|
|
Line has trailing spaces. |
77
|
|
Line has trailing spaces. |
80
|
|
Line has trailing spaces. |
81
|
|
Missing a Javadoc comment. |
81
|
|
Line has trailing spaces. |
83
|
|
Missing a Javadoc comment. |
83
|
|
Line has trailing spaces. |
85
|
|
Missing a Javadoc comment. |
85
|
|
Missing a Javadoc comment. |
87
|
|
Missing a Javadoc comment. |
89
|
|
Missing a Javadoc comment. |
91
|
|
Missing a Javadoc comment. |
93
|
|
Line has trailing spaces. |
94
|
|
Missing a Javadoc comment. |
95
|
|
Missing a Javadoc comment. |
97
|
|
Missing a Javadoc comment. |
99
|
|
Missing a Javadoc comment. |
101
|
|
Missing a Javadoc comment. |
103
|
|
Missing a Javadoc comment. |
105
|
|
Missing a Javadoc comment. |
107
|
|
Missing a Javadoc comment. |
109
|
|
Missing a Javadoc comment. |
111
|
|
Missing a Javadoc comment. |
113
|
|
Missing a Javadoc comment. |
115
|
|
Missing a Javadoc comment. |
117
|
|
Missing a Javadoc comment. |
119
|
|
Missing a Javadoc comment. |
121
|
org/apache/torque/util/SqlExpression.java
| Error |
Line |
|
Utility classes should not have a public or default constructor. |
87
|
|
Parameter column should be final. |
102
|
|
Parameter relatedColumn should be final. |
102
|
|
Parameter column should be final. |
120
|
|
Parameter relatedColumn should be final. |
121
|
|
Parameter ignoreCase should be final. |
122
|
|
Parameter db should be final. |
123
|
|
Avoid inline conditionals. |
125
|
|
'25' is a magic number. |
125
|
|
Parameter column should be final. |
144
|
|
Parameter relatedColumn should be final. |
145
|
|
Parameter ignoreCase should be final. |
146
|